From: Eran Ben-Avi Subject: improper initialization of ipsec_table in openswan 2.4.9 Date: Tue, 6 Nov 2007 04:04:12 -0800 (PST) Message-ID: <537818.31005.qm@web62507.mail.re1.yahoo.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="0-1932733950-1194350652=:31005" To: linux-crypto@vger.kernel.org Return-path: Received: from web62507.mail.re1.yahoo.com ([69.147.75.99]:30494 "HELO web62507.mail.re1.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1755458AbXKFMEN (ORCPT ); Tue, 6 Nov 2007 07:04:13 -0500 Sender: linux-crypto-owner@vger.kernel.org List-Id: linux-crypto.vger.kernel.org --0-1932733950-1194350652=:31005 Content-Type: text/plain; charset=us-ascii Hi, While working with openswan 2.4.9 on kernel 2.6.22.7 I found a bug in file sysctl_net_ipsec.c. The initialization of ipsec_table is improper for newer kernel versions since ctl_table structure was updated. The 7th parameter which refer to *parent was initialized mistakenly with *proc_handler as it was in older kernel versions. As a result ipsec proc entries under /proc/sys/net/ipsec were created as directories instead of files which led to improper behavior of openswan. Patch attached - the patch is only for newer kernel versions.Ofcourse it should be updated for backward compatibility. Regards, Eran Ben-Avi __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com --0-1932733950-1194350652=:31005 Content-Type: text/x-patch; name="=?utf-8?q?sysctl.patch?=" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="=?utf-8?q?sysctl.patch?=" LS0tIGxpbnV4L25ldC9pcHNlYy9zeXNjdGxfbmV0X2lwc2VjLmMJMjAwNC0w Ny0xMCAxNzoxMToxOC4wMDAwMDAwMDAgLTAyMDAKKysrIC4uL29wZW5zd2Fu LTIuNC45X2EvbGludXgvbmV0L2lwc2VjL3N5c2N0bF9uZXRfaXBzZWMuYwky MDA3LTExLTA2IDExOjEzOjEzLjAwMDAwMDAwMCAtMDIwMApAQCAtNzQsNDUg Kzc0LDQ1IEBACiBzdGF0aWMgY3RsX3RhYmxlIGlwc2VjX3RhYmxlW10gPSB7 CiAjaWZkZWYgQ09ORklHX0tMSVBTX0RFQlVHCiAJeyBORVRfSVBTRUNfREVC VUdfQUgsICJkZWJ1Z19haCIsICZkZWJ1Z19haCwKLQkgIHNpemVvZihpbnQp LCAwNjQ0LCBOVUxMLCAmcHJvY19kb2ludHZlY30sICAgIAorCSAgc2l6ZW9m KGludCksIDA2NDQsIE5VTEwsIE5VTEwsICZwcm9jX2RvaW50dmVjfSwgICAg CiAJeyBORVRfSVBTRUNfREVCVUdfRVNQLCAiZGVidWdfZXNwIiwgJmRlYnVn X2VzcCwKLQkgIHNpemVvZihpbnQpLCAwNjQ0LCBOVUxMLCAmcHJvY19kb2lu dHZlY30sICAgIAorCSAgc2l6ZW9mKGludCksIDA2NDQsIE5VTEwsIE5VTEws ICZwcm9jX2RvaW50dmVjfSwgICAgCiAJeyBORVRfSVBTRUNfREVCVUdfVFVO TkVMLCAiZGVidWdfdHVubmVsIiwgJmRlYnVnX3R1bm5lbCwKLQkgIHNpemVv ZihpbnQpLCAwNjQ0LCBOVUxMLCAmcHJvY19kb2ludHZlY30sICAgIAorCSAg c2l6ZW9mKGludCksIDA2NDQsIE5VTEwsIE5VTEwsICZwcm9jX2RvaW50dmVj fSwgICAgCiAJeyBORVRfSVBTRUNfREVCVUdfRVJPVVRFLCAiZGVidWdfZXJv dXRlIiwgJmRlYnVnX2Vyb3V0ZSwKLQkgIHNpemVvZihpbnQpLCAwNjQ0LCBO VUxMLCAmcHJvY19kb2ludHZlY30sICAgIAorCSAgc2l6ZW9mKGludCksIDA2 NDQsIE5VTEwsIE5VTEwsICZwcm9jX2RvaW50dmVjfSwgICAgCiAJeyBORVRf SVBTRUNfREVCVUdfU1BJLCAiZGVidWdfc3BpIiwgJmRlYnVnX3NwaSwKLQkg IHNpemVvZihpbnQpLCAwNjQ0LCBOVUxMLCAmcHJvY19kb2ludHZlY30sICAg IAorCSAgc2l6ZW9mKGludCksIDA2NDQsIE5VTEwsIE5VTEwsICZwcm9jX2Rv aW50dmVjfSwgICAgCiAJeyBORVRfSVBTRUNfREVCVUdfUkFESUosICJkZWJ1 Z19yYWRpaiIsICZkZWJ1Z19yYWRpaiwKLQkgIHNpemVvZihpbnQpLCAwNjQ0 LCBOVUxMLCAmcHJvY19kb2ludHZlY30sICAgIAorCSAgc2l6ZW9mKGludCks IDA2NDQsIE5VTEwsIE5VTEwsICZwcm9jX2RvaW50dmVjfSwgICAgCiAJeyBO RVRfSVBTRUNfREVCVUdfTkVUTElOSywgImRlYnVnX25ldGxpbmsiLCAmZGVi dWdfbmV0bGluaywKLQkgIHNpemVvZihpbnQpLCAwNjQ0LCBOVUxMLCAmcHJv Y19kb2ludHZlY30sICAgIAorCSAgc2l6ZW9mKGludCksIDA2NDQsIE5VTEws IE5VTEwsICZwcm9jX2RvaW50dmVjfSwgICAgCiAJeyBORVRfSVBTRUNfREVC VUdfWEZPUk0sICJkZWJ1Z194Zm9ybSIsICZkZWJ1Z194Zm9ybSwKLQkgIHNp emVvZihpbnQpLCAwNjQ0LCBOVUxMLCAmcHJvY19kb2ludHZlY30sICAgIAor CSAgc2l6ZW9mKGludCksIDA2NDQsIE5VTEwsIE5VTEwsICZwcm9jX2RvaW50 dmVjfSwgICAgCiAJeyBORVRfSVBTRUNfREVCVUdfUkNWLCAiZGVidWdfcmN2 IiwgJmRlYnVnX3JjdiwKLQkgIHNpemVvZihpbnQpLCAwNjQ0LCBOVUxMLCAm cHJvY19kb2ludHZlY30sICAgIAorCSAgc2l6ZW9mKGludCksIDA2NDQsIE5V TEwsIE5VTEwsICZwcm9jX2RvaW50dmVjfSwgICAgCiAJeyBORVRfSVBTRUNf REVCVUdfUEZLRVksICJkZWJ1Z19wZmtleSIsICZkZWJ1Z19wZmtleSwKLQkg IHNpemVvZihpbnQpLCAwNjQ0LCBOVUxMLCAmcHJvY19kb2ludHZlY30sICAg IAorCSAgc2l6ZW9mKGludCksIDA2NDQsIE5VTEwsIE5VTEwsICZwcm9jX2Rv aW50dmVjfSwgICAgCiAJeyBORVRfSVBTRUNfREVCVUdfVkVSQk9TRSwgImRl YnVnX3ZlcmJvc2UiLCZzeXNjdGxfaXBzZWNfZGVidWdfdmVyYm9zZSwKLQkg IHNpemVvZihpbnQpLCAwNjQ0LCBOVUxMLCAmcHJvY19kb2ludHZlY30sICAg IAorCSAgc2l6ZW9mKGludCksIDA2NDQsIE5VTEwsIE5VTEwsICZwcm9jX2Rv aW50dmVjfSwgICAgCiAjaWZkZWYgQ09ORklHX0tMSVBTX0lQQ09NUAogCXsg TkVUX0lQU0VDX0RFQlVHX0lQQ09NUCwgImRlYnVnX2lwY29tcCIsICZzeXNj dGxfaXBzZWNfZGVidWdfaXBjb21wLAotCSAgc2l6ZW9mKGludCksIDA2NDQs IE5VTEwsICZwcm9jX2RvaW50dmVjfSwgICAgCisJICBzaXplb2YoaW50KSwg MDY0NCwgTlVMTCwgTlVMTCwgJnByb2NfZG9pbnR2ZWN9LCAgICAKICNlbmRp ZiAvKiBDT05GSUdfS0xJUFNfSVBDT01QICovCiAKICNpZmRlZiBDT05GSUdf S0xJUFNfUkVHUkVTUwogCXsgTkVUX0lQU0VDX1JFR1JFU1NfUEZLRVlfTE9T U0FHRSwgInBma2V5X2xvc3NhZ2UiLAogCSAgJnN5c2N0bF9pcHNlY19yZWdy ZXNzX3Bma2V5X2xvc3NhZ2UsCi0JICBzaXplb2YoaW50KSwgMDY0NCwgTlVM TCwgJnByb2NfZG9pbnR2ZWN9LAorCSAgc2l6ZW9mKGludCksIDA2NDQsIE5V TEwsIE5VTEwsICZwcm9jX2RvaW50dmVjfSwKICNlbmRpZiAvKiBDT05GSUdf S0xJUFNfUkVHUkVTUyAqLwogCiAjZW5kaWYgLyogQ09ORklHX0tMSVBTX0RF QlVHICovCiAJeyBORVRfSVBTRUNfSUNNUCwgImljbXAiLCAmc3lzY3RsX2lw c2VjX2ljbXAsCi0JICBzaXplb2YoaW50KSwgMDY0NCwgTlVMTCwgJnByb2Nf ZG9pbnR2ZWN9LCAgICAKKwkgIHNpemVvZihpbnQpLCAwNjQ0LCBOVUxMLCBO VUxMLCAmcHJvY19kb2ludHZlY30sICAgIAogCXsgTkVUX0lQU0VDX0lOQk9V TkRfUE9MSUNZX0NIRUNLLCAiaW5ib3VuZF9wb2xpY3lfY2hlY2siLCAmc3lz Y3RsX2lwc2VjX2luYm91bmRfcG9saWN5X2NoZWNrLAotCSAgc2l6ZW9mKGlu dCksIDA2NDQsIE5VTEwsICZwcm9jX2RvaW50dmVjfSwgICAgCisJICBzaXpl b2YoaW50KSwgMDY0NCwgTlVMTCwgTlVMTCwgJnByb2NfZG9pbnR2ZWN9LCAg ICAKIAl7IE5FVF9JUFNFQ19UT1MsICJ0b3MiLCAmc3lzY3RsX2lwc2VjX3Rv cywKLQkgIHNpemVvZihpbnQpLCAwNjQ0LCBOVUxMLCAmcHJvY19kb2ludHZl Y30sICAgIAorCSAgc2l6ZW9mKGludCksIDA2NDQsIE5VTEwsIE5VTEwsICZw cm9jX2RvaW50dmVjfSwgICAgCiAJezB9CiB9OwogCg== --0-1932733950-1194350652=:31005--