From: David Miller Subject: Re: [camellia-oss:00952] Re: [PATCH 5/5] camellia: de-unrolling, 64bit-ization Date: Tue, 13 Nov 2007 22:10:41 -0800 (PST) Message-ID: <20071113.221041.47706914.davem@davemloft.net> References: <200711131947.09040.vda.linux@googlemail.com> <20071113.194952.229187981.davem@davemloft.net> <200711132230.47844.vda.linux@googlemail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: takamiya@po.ntts.co.jp, herbert@gondor.apana.org.au, linux-crypto@vger.kernel.org To: vda.linux@googlemail.com Return-path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:41184 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1750779AbXKNGKm (ORCPT ); Wed, 14 Nov 2007 01:10:42 -0500 In-Reply-To: <200711132230.47844.vda.linux@googlemail.com> Sender: linux-crypto-owner@vger.kernel.org List-Id: linux-crypto.vger.kernel.org From: Denys Vlasenko Date: Tue, 13 Nov 2007 22:30:47 -0700 > On Tuesday 13 November 2007 20:49, David Miller wrote: > > From: Denys Vlasenko > > Date: Tue, 13 Nov 2007 19:47:08 -0700 > > > > > If CONFIG_CC_OPTIMIZE_FOR_SIZE is not an acceptable method, > > > do you have other ideas? > > > > Look at ways to make the code run faster without loop unrolling? > > I did it. I noticed that key setup is mostly operating on 64-bit > quantities, and provided alternative implementation which > exploits that fact. It's smaller and faster. Great, then you don't have to unroll the loop and performance is at least as good as before _and_ you save code space. It's perfect, you don't need compile time checks or anything silly like that. Please submit this new version :-)