From: Herbert Xu Subject: Re: [PATCH 2/2] tcrypt.h: AES CTR large test vector Date: Fri, 30 Nov 2007 00:39:44 +1100 Message-ID: <20071129133943.GG8487@gondor.apana.org.au> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Linux Crypto To: Tan Swee Heng Return-path: Received: from rhun.apana.org.au ([64.62.148.172]:3835 "EHLO arnor.apana.org.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755098AbXK2Njr (ORCPT ); Thu, 29 Nov 2007 08:39:47 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-crypto-owner@vger.kernel.org List-Id: linux-crypto.vger.kernel.org On Wed, Nov 28, 2007 at 07:31:30AM +0800, Tan Swee Heng wrote: > This patch adds a large AES CTR mode test vector. The test vector is > 4100 bytes in size. It was generated using a C++ program that called > Crypto++. > > Note that this patch increases considerably the size of "struct > cipher_testvec" and hence the size of tcrypt.ko. > > Signed-off-by: Tan Swee Heng Patch applied. It's a good thing modules use vmalloc and tcrypt doesn't have to stay loaded :) Longer term we want to 1) Split tcrypt into core and algorithm-specific chunks. Have each algorithm produce its own tcrypt module. 2) Change these staticly sized arrays to something a bit more flexible. Hopefully your addition will actually prompt someone (other than me :) to do these things. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt