From: "rae l" Subject: Re: [PATCH] [RESEND] crypto test: use print_hex_dump from kernel.h instead Date: Fri, 30 Nov 2007 09:20:34 +0800 Message-ID: <91b13c310711291720p1dde31b9k1f974025b01703cf@mail.gmail.com> References: <20071126143939.GB28022@gondor.apana.org.au> <1196098095-8995-1-git-send-email-crquan@gmail.com> <1196100104.31590.11.camel@localhost> <20071127013540.GA793@gondor.apana.org.au> <1196131632-7285-1-git-send-email-crquan@gmail.com> <474B87F1.2060109@student.ltu.se> <91b13c310711262103w781b3047k6338acda56837c0@mail.gmail.com> <20071127012622.3e3a6bd1.akpm@linux-foundation.org> <20071129111324.GH22537@gondor.apana.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: "Andrew Morton" , "Richard Knutsson" , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, dengxw@163.com, "Randy Dunlap" , "Joe Perches" To: "Herbert Xu" Return-path: Received: from nf-out-0910.google.com ([64.233.182.185]:54673 "EHLO nf-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932291AbXK3BUg (ORCPT ); Thu, 29 Nov 2007 20:20:36 -0500 Received: by nf-out-0910.google.com with SMTP id g13so2075451nfb for ; Thu, 29 Nov 2007 17:20:34 -0800 (PST) In-Reply-To: <20071129111324.GH22537@gondor.apana.org.au> Content-Disposition: inline Sender: linux-crypto-owner@vger.kernel.org List-Id: linux-crypto.vger.kernel.org On Nov 29, 2007 7:13 PM, Herbert Xu wrote: ... > > uninlining this function shrinks crypto/tcrypt.o's .text from 20,009 bytes > > down to 19,701. > > > > inlining is almost always wrong. > > I agree. Please do as Andrew suggests and resubmit. inline disabled. Cc: Randy Dunlap Signed-off-by: Denis Cheng --- diff --git a/crypto/tcrypt.c b/crypto/tcrypt.c index 24141fb..13efc72 100644 --- a/crypto/tcrypt.c +++ b/crypto/tcrypt.c @@ -83,10 +83,9 @@ static char *check[] = { static void hexdump(unsigned char *buf, unsigned int len) { - while (len--) - printk("%02x", *buf++); - - printk("\n"); + print_hex_dump(KERN_CONT, "", DUMP_PREFIX_OFFSET, + 16, 1, + buf, len, false); } static void tcrypt_complete(struct crypto_async_request *req, int err) -- Denis Cheng