From: Herbert Xu Subject: Re: [patch 1/2] hw_random: allow rng_dev_read() to return hardware errors. Date: Mon, 31 Mar 2008 22:19:43 +0800 Message-ID: <20080331141943.GA14688@gondor.apana.org.au> References: <20080314092523.147382820@de.ibm.com> <20080314093046.656233449@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, Ralph Wuerthner , Andrew Morton To: Martin Schwidefsky Return-path: Received: from rhun.apana.org.au ([64.62.148.172]:55823 "EHLO arnor.apana.org.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750788AbYCaOTv (ORCPT ); Mon, 31 Mar 2008 10:19:51 -0400 Content-Disposition: inline In-Reply-To: <20080314093046.656233449@de.ibm.com> Sender: linux-crypto-owner@vger.kernel.org List-ID: On Fri, Mar 14, 2008 at 09:25:24AM +0000, Martin Schwidefsky wrote: > From: Ralph Wuerthner > > The api for hardware random number generators is currently limited to > devices that never fail. If the hardware is registered as a source for > random numbers it has to work. This prevents the use of i/o based > random number devices where the i/o might fail. > > Add a check for errors after the read from a hardware random number device. > > This patch is required to support large random numbers retrieved > from the CEX2C cards on System z. > > Signed-off-by: Ralph Wuerthner > Signed-off-by: Martin Schwidefsky Thanks for the patch. I'll pick this up in cryptodev-2.6. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt