From: "Mike Frysinger" Subject: Re: [2.6 patch] add include/asm-avr32/xor.h Date: Mon, 14 Apr 2008 18:11:45 -0400 Message-ID: <8bd0f97a0804141511o28385fcfl11923148f7fe701a@mail.gmail.com> References: <20080414141632.GA6695@cs181133002.pp.htv.fi> <20080414181140.GA813@Chamillionaire.breakpoint.cc> <20080414181536.GZ6695@cs181133002.pp.htv.fi> <20080414214640.GA2282@Chamillionaire.breakpoint.cc> <20080414220129.GH26885@cs181133002.pp.htv.fi> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: "Sebastian Siewior" , hskinnemoen@atmel.com, herbert@gondor.apana.org.au, davem@davemloft.net, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, shannon.nelson@intel.com, dan.j.williams@intel.com To: "Adrian Bunk" Return-path: Received: from wf-out-1314.google.com ([209.85.200.174]:12833 "EHLO wf-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751007AbYDNWLq (ORCPT ); Mon, 14 Apr 2008 18:11:46 -0400 Received: by wf-out-1314.google.com with SMTP id 28so1695200wff.4 for ; Mon, 14 Apr 2008 15:11:45 -0700 (PDT) In-Reply-To: <20080414220129.GH26885@cs181133002.pp.htv.fi> Content-Disposition: inline Sender: linux-crypto-owner@vger.kernel.org List-ID: On Mon, Apr 14, 2008 at 6:01 PM, Adrian Bunk wrote: > On Mon, Apr 14, 2008 at 11:46:40PM +0200, Sebastian Siewior wrote: > > so most > > xor.h files are identical copies and this is probably as bad as a > > trailing white space :) > > I'm not sure whether it's worth spending my time discussing whether > adding a config variable to 6 architectures is really better than > adding trivial headers to 3 architectures... long term robustness for new ports/codedrops indicates that having a common header in linux/ and making arches opt-in via Kconfig/whatever makes life a lot easier for everyone everything builds by default with the generic C versions and arches dont have to go through and figure out all the fun little stub files they need to straight copy from other architectures ... they only have to care if they want to implement an optimized version -mike