From: "Dan Williams" Subject: Re: [2.6 patch] add include/asm-avr32/xor.h Date: Mon, 14 Apr 2008 16:45:37 -0700 Message-ID: References: <20080414141632.GA6695@cs181133002.pp.htv.fi> <20080414181140.GA813@Chamillionaire.breakpoint.cc> <20080414181536.GZ6695@cs181133002.pp.htv.fi> <20080414214640.GA2282@Chamillionaire.breakpoint.cc> <20080414220129.GH26885@cs181133002.pp.htv.fi> <8bd0f97a0804141511o28385fcfl11923148f7fe701a@mail.gmail.com> <8bd0f97a0804141530i7c6ee03codeb0a546d333cb2f@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: "Adrian Bunk" , "Sebastian Siewior" , hskinnemoen@atmel.com, herbert@gondor.apana.org.au, davem@davemloft.net, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, shannon.nelson@intel.com To: "Mike Frysinger" Return-path: In-Reply-To: <8bd0f97a0804141530i7c6ee03codeb0a546d333cb2f@mail.gmail.com> Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-crypto.vger.kernel.org On Mon, Apr 14, 2008 at 3:30 PM, Mike Frysinger wrote: > On Mon, Apr 14, 2008 at 6:27 PM, Dan Williams wrote: > > "arches" did not have to go through and figure out the fun little stub > > file for xor.h. Adrian already made your "life easier". > > actually he didnt. he posted a fix for avr32. i dont care about > avr32, i'm a blackfin guy. he also wouldnt have had to do anything at > all if everything was handled with indirection in linux/xor.h. > > your point also is irrelevant in the case of new architectures. poor > microblaze for example. > Don't get me wrong I see the pain-reducing-value in codifying all the features that have architecture specific aspects with HAVE_* config variables. But in this case I think a 6 line patch per new arch gets the immediate job done. Regards, Dan