From: Herbert Xu Subject: Re: [PATCH 1/3] [CRYPTO] hash: Add Async Hash Support Date: Wed, 14 May 2008 20:40:39 +0800 Message-ID: <20080514124039.GA22902@gondor.apana.org.au> References: <20080122231818.GB6920@Chamillionaire.breakpoint.cc> <002d01c85d66$11e1d7c0$5c05420a@amcc.com> <004601c85ecd$1eb53d80$5c05420a@amcc.com> <004a01c85efc$56f2ee70$5c05420a@amcc.com> <20080313114230.GC8393@gondor.apana.org.au> <0CA0A16855646F4FA96D25A158E299D6044D6442@SDCEXCHANGE01.ad.amcc.com> <20080422111635.GA19543@gondor.apana.org.au> <0CA0A16855646F4FA96D25A158E299D6045B3153@SDCEXCHANGE01.ad.amcc.com> <20080507130047.GA26872@gondor.apana.org.au> <0CA0A16855646F4FA96D25A158E299D60472077B@SDCEXCHANGE01.ad.amcc.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-crypto@vger.kernel.org To: Loc Ho Return-path: Received: from rhun.apana.org.au ([64.62.148.172]:57249 "EHLO arnor.apana.org.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1757468AbYENMkm (ORCPT ); Wed, 14 May 2008 08:40:42 -0400 Content-Disposition: inline In-Reply-To: <0CA0A16855646F4FA96D25A158E299D60472077B@SDCEXCHANGE01.ad.amcc.com> Sender: linux-crypto-owner@vger.kernel.org List-ID: On Tue, May 13, 2008 at 01:27:27PM -0700, Loc Ho wrote: > > Please note: > 1. ahash_request has an extra variable 'void *info' for future uses with > KASUMI That's fine. We can change this structure at will. > 2. Any particular reason for removing ahash_nosetkey from function > crypto_init_ahash_ops - This would be an error check for digest if some > caller called setkey function for digest algorithm. All ahash algorithms should provide a setkey function just like hash. Digest algorithms should never come down this way. When we convert digest algorithms over to ahash we should add setkey functions. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt