From: Evgeniy Polyakov Subject: Re: [PATCH 2/2] talitos: Freescale integrated security engine (SEC) driver Date: Mon, 2 Jun 2008 20:00:12 +0400 Message-ID: <20080602160012.GB32511@2ka.mipt.ru> References: <4840585D.8050805@freescale.com> <20080530151638.087970ab.kim.phillips@freescale.com> <4840615F.4070103@freescale.com> <20080530153505.21eb1ec4.kim.phillips@freescale.com> <48406562.4010306@freescale.com> <20080530154820.6e56b625.kim.phillips@freescale.com> <20080530211204.GA15768@2ka.mipt.ru> <20080530171930.61965d59.kim.phillips@freescale.com> <20080531095901.GA16281@2ka.mipt.ru> <20080602092701.9d0d56e8.kim.phillips@freescale.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Scott Wood , linuxppc-dev@ozlabs.org, mr.scada@gmail.com, linux-crypto@vger.kernel.org, herbert@gondor.apana.org.au To: Kim Phillips Return-path: Received: from relay.2ka.mipt.ru ([194.85.82.65]:35338 "EHLO 2ka.mipt.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752662AbYFBQBK (ORCPT ); Mon, 2 Jun 2008 12:01:10 -0400 Content-Disposition: inline In-Reply-To: <20080602092701.9d0d56e8.kim.phillips@freescale.com> Sender: linux-crypto-owner@vger.kernel.org List-ID: On Mon, Jun 02, 2008 at 09:27:01AM -0500, Kim Phillips (kim.phillips@freescale.com) wrote: > > I meant descriptor hdr value accessed via it - can it be checked in > > tasklet under the lock and in submit path without? Can they correlate > > somehow? > > I believe the check for a non-null request->desc (under lock) before > the hdr value is accessed ensures this doesn't happen. But can it be changed? You write to it without lock, but read under the one (different for each channel though), so it attracted attention. -- Evgeniy Polyakov