From: Herbert Xu Subject: Re: [PATCH] prng: fix a few misc bugs in prng Date: Thu, 17 Jul 2008 15:46:15 +0800 Message-ID: <20080717074615.GA23621@gondor.apana.org.au> References: <20080716202916.GA1648@hmsreliant.think-freely.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, davem@davemloft.net To: Neil Horman Return-path: Received: from rhun.apana.org.au ([64.62.148.172]:34321 "EHLO arnor.apana.org.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753570AbYGQHqT (ORCPT ); Thu, 17 Jul 2008 03:46:19 -0400 Content-Disposition: inline In-Reply-To: <20080716202916.GA1648@hmsreliant.think-freely.org> Sender: linux-crypto-owner@vger.kernel.org List-ID: On Wed, Jul 16, 2008 at 04:29:16PM -0400, Neil Horman wrote: > > Fixing a few misc bugs in prng.c: > - Remove prng_key/prng_iv from prng_context (both kept in tfm ptr) > - Making _get_more_prng_bytes return meaningful err codes (not just -1/0) > > Signed-off-by: Neil Horman Applied to cryptodev-2.6. > @@ -369,8 +362,7 @@ int reset_prng_context(struct prng_context *ctx, > > ctx->rand_data_valid = DEFAULT_BLK_SZ; > > - ret = crypto_blkcipher_setkey(ctx->tfm, ctx->prng_key, > - strlen(ctx->prng_key)); > + ret = crypto_blkcipher_setkey(ctx->tfm, prng_key, strlen(prng_key)); Please make the length a parameter instead as it's much more convenient to use a blob as a key rather than a string. > diff --git a/firmware/Makefile b/firmware/Makefile > index 809a526..3515814 100644 > --- a/firmware/Makefile > +++ b/firmware/Makefile > @@ -34,8 +34,8 @@ fw-shipped-$(CONFIG_SND_SB16_CSP) += sb16/mulaw_main.csp sb16/alaw_main.csp \ > sb16/ima_adpcm_capture.csp > fw-shipped-$(CONFIG_SND_YMFPCI) += yamaha/ds1_ctrl.fw yamaha/ds1_dsp.fw \ > yamaha/ds1e_ctrl.fw > -fw-shipped-$(CONFIG_TIGON3) += tigon/tg3.bin tigon/tg3_tso.bin \ > - tigon/tg3_tso5.bin > +#fw-shipped-$(CONFIG_TIGON3) += tigon/tg3.bin tigon/tg3_tso.bin \ > +# tigon/tg3_tso5.bin > fw-shipped-$(CONFIG_USB_DABUSB) += dabusb/firmware.fw dabusb/bitstream.bin > fw-shipped-$(CONFIG_USB_EMI26) += emi26/loader.fw emi26/firmware.fw \ > emi26/bitstream.fw The dreaded firmware makes a comeback :) Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt