From: "Benoit Boissinot" Subject: Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC32c algorithm by new crypto API. Date: Mon, 4 Aug 2008 20:02:37 +0200 Message-ID: <40f323d00808041102s276c065fn8db6f5a79fdf7ad1@mail.gmail.com> References: <1217857537.29139.70.camel@think.oraclecorp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: "Chris Mason" , dwmw2@infradead.org, austin_zhang@linux.intel.com, davem@davemloft.net, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org To: "Herbert Xu" Return-path: Received: from yx-out-2324.google.com ([74.125.44.30]:26083 "EHLO yx-out-2324.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753287AbYHDSCi (ORCPT ); Mon, 4 Aug 2008 14:02:38 -0400 Received: by yx-out-2324.google.com with SMTP id 8so188631yxm.1 for ; Mon, 04 Aug 2008 11:02:37 -0700 (PDT) In-Reply-To: Content-Disposition: inline Sender: linux-crypto-owner@vger.kernel.org List-ID: On Mon, Aug 4, 2008 at 5:42 PM, Herbert Xu wrote: > Chris Mason wrote: >> >>>From a performance point of view I'm probably reading the crypto API >> code wrong, but it looks like my choices are to either have a long >> standing context and use locking around the digest/hash calls to protect >> internal crypto state, or create a new context every time and take a >> perf hit while crypto looks up the right module. > > You're looking at the old hash interface. New users should use the > ahash interface which was only recently added to the kernel. It > lets you store the state in the request object which you pass to > the algorithm on every call. This means that you only need one > tfm in the entire system for crc32c. > > BTW, don't let the a in ahash intimidate you. It's meant to support > synchronous implementations such as the Intel instruction just as > well as asynchronous ones. Since I couldn't find any ahash user in the tree (outside of tcrypt.c), can you provide some example source code as to how to use it (especially synchonously). For example the code for the digest_null testing would be fine. regards, Benoit