From: Austin Zhang Subject: Re: [PATCH] Using Intel CRC32 instruction to accelerate CRC32c algorithm by new crypto API. Date: Tue, 05 Aug 2008 05:59:11 -0400 Message-ID: <1217930351.1613.4.camel@localhost.localdomain> References: <1217842507.20845.18.camel@localhost.localdomain> <20080804141916.GC11415@gondor.apana.org.au> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org To: Herbert Xu Return-path: Received: from mga10.intel.com ([192.55.52.92]:49757 "EHLO fmsmga102.fm.intel.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755042AbYHEKA4 (ORCPT ); Tue, 5 Aug 2008 06:00:56 -0400 In-Reply-To: <20080804141916.GC11415@gondor.apana.org.au> Sender: linux-crypto-owner@vger.kernel.org List-ID: On Mon, 2008-08-04 at 22:19 +0800, Herbert Xu wrote: > On Mon, Aug 04, 2008 at 05:35:07AM -0400, Austin Zhang wrote: > > > > +config CRYPTO_CRC32C_INTEL > > + tristate "CRC32c INTEL hardware acceleration" > > + select CRYPTO_HASH > > You need some sort of a dependency here. See what the other > assembly algorithms do it. > > Cheers, How about: +config CRYPTO_CRC32C_INTEL + tristate "CRC32c INTEL hardware acceleration" + depends on X86 + select CRYPTO_ALGAPI + help + In Intel processor with SSE4.2 supported, the processor will ...... It should only depend on X86.