From: Jeff Garzik Subject: Re: [PATCH] crypto: add test vectors for skein256/512/1024 Date: Sun, 02 Nov 2008 20:36:30 -0500 Message-ID: <490E559E.7080900@garzik.org> References: <20081102161506.GA21940@havoc.gtf.org> <20081102201518.GA23620@Chamillionaire.breakpoint.cc> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: herbert@gondor.apana.org.au, davem@davemloft.net, linux-crypto@vger.kernel.org, LKML To: Sebastian Andrzej Siewior Return-path: Received: from srv5.dvmed.net ([207.36.208.214]:43249 "EHLO mail.dvmed.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753752AbYKCBgo (ORCPT ); Sun, 2 Nov 2008 20:36:44 -0500 In-Reply-To: <20081102201518.GA23620@Chamillionaire.breakpoint.cc> Sender: linux-crypto-owner@vger.kernel.org List-ID: Sebastian Andrzej Siewior wrote: > I grabed them from http://www.schneier.com/skein.html. The last test vector > (3) in every category is currently deactivated because it failed always. > It is unlikely that I made a type because I copy+pasted the tables + vim > magiced them. So maybe code may missbehave on requests lengths which are > not a multiple of 4 or the vectors can not be used due to some other > limitations that I've overseen. > > Signed-off-by: Sebastian Andrzej Siewior > --- > crypto/tcrypt.c | 24 ++++++++ > crypto/testmgr.c | 27 +++++++++ > crypto/testmgr.h | 166 +++++++++++++++++++++++++++++++++++++++++++++++++++++- > 3 files changed, 216 insertions(+), 1 deletions(-) Nice, thanks! I'm wondering if the failure has to do with the alignmask value in struct crypto_alg for each variant. Jeff