From: Herbert Xu Subject: Re: [PATCH linux-next] : Tree for November 12 (libcrc32c) Date: Thu, 13 Nov 2008 22:09:28 +0800 Message-ID: <20081113140928.GC31608@gondor.apana.org.au> References: <20081112182818.6e259488.sfr@canb.auug.org.au> <20081112130105.430c47e4.randy.dunlap@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Stephen Rothwell , akpm , linux-crypto@vger.kernel.org, linux-next@vger.kernel.org, LKML , davem@davemloft.net To: Randy Dunlap Return-path: Content-Disposition: inline In-Reply-To: <20081112130105.430c47e4.randy.dunlap@oracle.com> Sender: linux-next-owner@vger.kernel.org List-Id: linux-crypto.vger.kernel.org On Wed, Nov 12, 2008 at 01:01:05PM -0800, Randy Dunlap wrote: > From: Randy Dunlap > > libcrc32c uses CRYPTO interfaces so it should depend on CRYPTO. > > crypto/built-in.o: In function `crc32c_mod_init': > crc32c.c:(.init.text+0xc): undefined reference to `crypto_register_shash' > crypto/built-in.o: In function `crc32c_mod_fini': > crc32c.c:(.exit.text+0xc): undefined reference to `crypto_unregister_shash' > lib/built-in.o: In function `crc32c': > (.text+0xfcf9): undefined reference to `crypto_shash_update' > lib/built-in.o: In function `libcrc32c_mod_init': > libcrc32c.c:(.init.text+0x666): undefined reference to `crypto_alloc_shash' > lib/built-in.o: In function `libcrc32c_mod_fini': > libcrc32c.c:(.exit.text+0xc): undefined reference to `crypto_free_tfm' > > Signed-off-by: Randy Dunlap Thanks, I've fixed it as follows: commit d9cc217c79df50f9a9f7937aeaa54d89ae198686 Author: Herbert Xu Date: Thu Nov 13 22:05:13 2008 +0800 libcrc32c: Select CRYPTO in Kconfig Selecting CRYPTO_CRC32C is not enough as CRYPTO which CRYPTO_CRC32C depends on may be disabled. This patch adds the select on CRYPTO. Signed-off-by: Herbert Xu diff --git a/lib/Kconfig b/lib/Kconfig index d09edb7..963009a 100644 --- a/lib/Kconfig +++ b/lib/Kconfig @@ -64,6 +64,7 @@ config CRC7 config LIBCRC32C tristate "CRC32c (Castagnoli, et al) Cyclic Redundancy-Check" + select CRYPTO select CRYPTO_CRC32C help This option is provided for the case where no in-kernel-tree -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt