From: "Kay Sievers" Subject: Re: Runaway loop with the current git. Date: Sun, 7 Dec 2008 17:03:17 +0100 Message-ID: References: <20081207112335.0afd5192@lxorguk.ukuu.org.uk> <20081207155507.GA15355@gondor.apana.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: "Alan Cox" , zbr@ioremap.net, linux-kernel@vger.kernel.org, "Linux Crypto Mailing List" To: "Herbert Xu" Return-path: Received: from ey-out-2122.google.com ([74.125.78.26]:27368 "EHLO ey-out-2122.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754156AbYLGQDT (ORCPT ); Sun, 7 Dec 2008 11:03:19 -0500 Received: by ey-out-2122.google.com with SMTP id 6so303950eyi.37 for ; Sun, 07 Dec 2008 08:03:18 -0800 (PST) In-Reply-To: <20081207155507.GA15355@gondor.apana.org.au> Content-Disposition: inline Sender: linux-crypto-owner@vger.kernel.org List-ID: On Sun, Dec 7, 2008 at 16:55, Herbert Xu wrote: > On Sun, Dec 07, 2008 at 10:49:27PM +0800, Herbert Xu wrote: >> >> In any case the loop itself does not involve any crypto components >> so I don't think making changes in the crypto layer is going to >> make this go away forever as anyone calling request_module early >> enough will get into this loop. > > Having said that I think this patch should remove this particular > trigger. Unfortunately I couldn't find a more succinct way of > expressing this relationship: if ALGAPI is built-in because it's > selected by an algorithm, and CRYPTO_MANAGER is enabled then we > require CRYPTO_MANAGER to be built-in as well. > > Evgeniy, please let me know whether this fixes the problem. Even when this works around it, the problem that the kernel triggers module loading on /dev/console access stays and needs to be fixed instead. It's a pure kernel bug, regardless of how many times Alan likes to establish non-sensical hotplug rules to prevent this. The next innocent driver change, like yours is, will run into the same problem. Thanks, Kay