From: Alan Cox Subject: Re: Runaway loop with the current git. Date: Tue, 9 Dec 2008 10:13:32 +0000 Message-ID: <20081209101332.2b81601b@lxorguk.ukuu.org.uk> References: <20081207180302.339bf58d@lxorguk.ukuu.org.uk> <20081207181559.63549cfc@lxorguk.ukuu.org.uk> <20081207183112.3ef31caa@lxorguk.ukuu.org.uk> <20081207200008.5af2d1e9@lxorguk.ukuu.org.uk> <20081208011850.GA10289@mit.edu> <20081209010937.GL2501@mit.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Kay Sievers , Evgeniy Polyakov , Herbert Xu , linux-kernel@vger.kernel.org, Linux Crypto Mailing List To: Theodore Tso Return-path: Received: from earthlight.etchedpixels.co.uk ([81.2.110.250]:47693 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751466AbYLIKOA (ORCPT ); Tue, 9 Dec 2008 05:14:00 -0500 In-Reply-To: <20081209010937.GL2501@mit.edu> Sender: linux-crypto-owner@vger.kernel.org List-ID: > apparently not triggering, since it could be that Debian's initrd > might cause some other uncaught recursion loop if we don't drive this > problem determination to root cause. Agreed - and there are all sorts of obscure and wonderful other ways to trip this up which need the detector (AF_UNIX modular and doing a syslog for example). > > That's why I still think it's a good thing, to connect the core tty > > devices to their dev_t handler internally, before we init all the > > other drivers and run userspace. > > Um, how early? (/me searches lkml.org for the original patch). Ah, > OK, you want to do it postcore.... There may actually be a problem > with that, because it looks like vtconsole_class_init (which is > currently run as a postcore initcall) really wants to happen before > the tty layer initializes itself. So moving tty into postcore could > potentially run into problems, depending on whether vt.c's or > tty_io.c's initcalls are run first. Its playing with fire and doing so to paper over a completely different problem. The recursion detector is generic and should be sufficient. If it isn't then it needs improving to be generic, sufficient and working.