From: Herbert Xu Subject: Re: [PATCH] AMCC Crypto4xx Device Driver v5 Date: Thu, 29 Jan 2009 08:29:08 +1100 Message-ID: <20090128212908.GC22141@gondor.apana.org.au> References: <1231788650.5533.16.camel@jhsiao-usb> <20090128035937.GA13157@gondor.apana.org.au> <1233164516.4809.9.camel@jhsiao-usb> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kim.phillips@freescale.com, jwboyer@linux.vnet.ibm.com, linux-crypto@vger.kernel.org, linuxppc-dev@ozlabs.org To: James Hsiao Return-path: Received: from rhun.apana.org.au ([64.62.148.172]:44746 "EHLO arnor.apana.org.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751740AbZA1V3Q (ORCPT ); Wed, 28 Jan 2009 16:29:16 -0500 Content-Disposition: inline In-Reply-To: <1233164516.4809.9.camel@jhsiao-usb> Sender: linux-crypto-owner@vger.kernel.org List-ID: On Wed, Jan 28, 2009 at 09:41:56AM -0800, James Hsiao wrote: > > I will re submit the patch with proper changelog. > I had the change log this way is for the reviewer easy to see the > difference. But, I agree this is not proper for a newly created driver. Oh yeah I have nothing against the changelog you had but it should be present along with the patch description so it can actually be applied. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt