From: Herbert Xu Subject: Re: [PATCH] crypto: compress - Add pcomp interface Date: Tue, 10 Feb 2009 17:18:22 +1100 Message-ID: <20090210061822.GA19774@gondor.apana.org.au> References: <1231862386-11128-1-git-send-email-Geert.Uytterhoeven@sonycom.com> <1231862386-11128-2-git-send-email-Geert.Uytterhoeven@sonycom.com> <20090114031613.GA7429@gondor.apana.org.au> <20090115030526.GA27726@gondor.apana.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org To: Geert Uytterhoeven Return-path: Received: from rhun.apana.org.au ([64.62.148.172]:58475 "EHLO arnor.apana.org.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751075AbZBJGS0 (ORCPT ); Tue, 10 Feb 2009 01:18:26 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-crypto-owner@vger.kernel.org List-ID: On Thu, Feb 05, 2009 at 05:24:51PM +0100, Geert Uytterhoeven wrote: > > > Well with the netlink parameters these can have variable lengths > > depending on how many parameters the user supplies. > > How can this be exported to userspace? > How does this variable length parameter passing work? Do you have an example? See how we use it for rtnetlink, e.g., in net/ipv4/ip_gre.c. > Nothing in crypto/ seems to already use nla_*? Well we don't have a user-space API yet :) But checkout the discussions on this list. > While the core of the crypto system supports two algorithms of the same name > with different types, the testmgr doesn't. I was lazy :) But really it isn't too hard to add a type field to the array in testmgr. We don't even have to add it for existing entries (except for the ones that you're trying to replace, i.e., deflate). > As I removed the backwards-compatility layer at your request, I'll use "zlib" > for the name of the new module. It's more flexible than the fixed "deflate" > one anyway. > > Is this OK for you? Hmm, I think we need to have it stay as deflate if we're to make an easy transition for existing users (e.g., IPsec). Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt