From: Pekka Enberg Subject: Re: [PATCH] Export symbol ksize() Date: Tue, 17 Feb 2009 19:03:28 +0200 Message-ID: <84144f020902170903g5756cf4cy57f98cd5955ff2e3@mail.gmail.com> References: <1234272104-10211-1-git-send-email-kirill@shutemov.name> <20090212104349.GA13859@gondor.apana.org.au> <1234435521.28812.165.camel@penberg-laptop> <20090212105034.GC13859@gondor.apana.org.au> <1234454104.28812.175.camel@penberg-laptop> <20090215133638.5ef517ac.akpm@linux-foundation.org> <1234734194.5669.176.camel@calx> <20090215135555.688ae1a3.akpm@linux-foundation.org> <1234741781.5669.204.camel@calx> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Matt Mackall , Andrew Morton , Herbert Xu , "Kirill A. Shutemov" , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-crypto@vger.kernel.org, Geert.Uytterhoeven@sonycom.com To: Christoph Lameter Return-path: Received: from fg-out-1718.google.com ([72.14.220.158]:29806 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752694AbZBQRDb (ORCPT ); Tue, 17 Feb 2009 12:03:31 -0500 In-Reply-To: Sender: linux-crypto-owner@vger.kernel.org List-ID: On Tue, Feb 17, 2009 at 6:17 PM, Christoph Lameter wrote: > On Sun, 15 Feb 2009, Matt Mackall wrote: > >> And it -is- a category error. The fact that kmalloc is implemented on >> top of kmem_cache_alloc is an implementation detail that callers should >> not assume. They shouldn't call kfree() on kmem_cache_alloc objects >> (even though it might just happen to work), nor should they call >> ksize(). > > ksize does not take a kmem_cache pointer and it is mainly used for > figuring out how much space kmalloc really allocated for an object. As > such its more part of the kmalloc/kfree set of calls than the > kmem_cache_* calls. > > We could add another call > > kmem_cache_size() > > for symmetries sake. Hmm, kmem_cache_size() seems bit pointless to me. For kmem_cache_create()'d caches, actual allocated size should be more or less optimal with no extra space. Pekka