From: Randy Dunlap Subject: Re: linux-next: Tree for March 10 (crypto & NLATTR) Date: Tue, 10 Mar 2009 13:08:31 -0700 Message-ID: <49B6C8BF.8010105@oracle.com> References: <20090310195534.8f8f3c7a.sfr@canb.auug.org.au> <49B6B821.5050302@oracle.com> <10f740e80903101256v2cfe08a8g410c297e019d8693@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Stephen Rothwell , linux-next@vger.kernel.org, LKML , herbert@gondor.apana.org.au, David Miller , linux-crypto@vger.kernel.org To: Geert Uytterhoeven Return-path: Received: from rcsinet11.oracle.com ([148.87.113.123]:25648 "EHLO rgminet11.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757614AbZCJUHe (ORCPT ); Tue, 10 Mar 2009 16:07:34 -0400 In-Reply-To: <10f740e80903101256v2cfe08a8g410c297e019d8693@mail.gmail.com> Sender: linux-crypto-owner@vger.kernel.org List-ID: Geert Uytterhoeven wrote: > On Tue, Mar 10, 2009 at 19:57, Randy Dunlap wrote: >> Stephen Rothwell wrote: >>> Changes since 20090306: >>> >>> >>> The driver-core tree gained a build failure due to a conflict with the >>> crypto tree. I have applied a patch to the crypto tree for today. >> I had several (4 of 50) randconfig builds fail with: >> >> lib/built-in.o: In function `__nla_reserve_nohdr': >> (.text+0xd08d): undefined reference to `skb_put' >> lib/built-in.o: In function `__nla_reserve': >> (.text+0xd121): undefined reference to `skb_put' >> lib/built-in.o: In function `nla_append': >> (.text+0xd493): undefined reference to `skb_put' >> >> which happens with CONFIG_NET=n, CONFIG_CRYPTO=y, CONFIG_CRYPTO_ZLIB=[my]. >> >> CRYPTO_ZLIB selects NLATTR, but obviously the build of nlattr.c fails >> when CONFIG_NET=n. Should CRYPTO_ZLIB depend on NET? >> Please don't say that CRYPTO_ZLIB should select NET. > > Bummer, my fault (commit e9cc8bddaea3944fabfebb968bc88d603239beed, > netlink: Move netlink attribute parsing support to lib). > > Obviously I was only worried about crypto/zlib.c needing nlattr.c > without pulling in the whole networking code, not about nlattr.c > itself needing networking functionality. But still, how could I have > missed this compile failure? > > Does it sound sane to protect the routines that do call skb_put() by > #ifdef CONFIG_NET? I'll have to let David or Herbert answer that. From my quick look at the code, I don't see much use for nlattr.c when CONFIG_NET is not enabled. -- ~Randy