From: Matt Mackall Subject: Re: [PATCH] crypto: add optional continuous repetition test to entropy store based rngs Date: Fri, 12 Jun 2009 11:31:11 -0500 Message-ID: <1244824271.4496.151.camel@calx> References: <20090604195030.GA11300@hmsreliant.think-freely.org> <1244146450.22069.216.camel@calx> <20090605000456.GA10883@localhost.localdomain> <20090605003006.GA5236@gondor.apana.org.au> <20090605014816.GA15462@localhost.localdomain> <20090612142308.GA29341@hmsreliant.think-freely.org> <20090612142644.GA15644@gondor.apana.org.au> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: Neil Horman , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, davem@davemloft.net To: Herbert Xu Return-path: Received: from waste.org ([66.93.16.53]:33556 "EHLO waste.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932996AbZFLQbi (ORCPT ); Fri, 12 Jun 2009 12:31:38 -0400 In-Reply-To: <20090612142644.GA15644@gondor.apana.org.au> Sender: linux-crypto-owner@vger.kernel.org List-ID: On Sat, 2009-06-13 at 00:26 +1000, Herbert Xu wrote: > On Fri, Jun 12, 2009 at 10:23:08AM -0400, Neil Horman wrote: > > > > > Ok, that seems like a reasonable idea. new patch below > > > Change Notes: > > > > > > 1) Moved fips_enabled flag into its own header, included in all the appropriate > > > places > > > > > > 2) removed flags field from entropy store, keying continuous test on the > > > non-null status of the last_data pointer > > > > > > > > > FIPS-140 requires that all random number generators implement continuous self > > > tests in which each extracted block of data is compared against the last block > > > for repetition. The ansi_cprng implements such a test, but it would be nice if > > > the hw rng's did the same thing. Obviously its not something thats always > > > needed, but it seems like it would be a nice feature to have on occasion. I've > > > written the below patch which allows individual entropy stores to be flagged as > > > desiring a continuous test to be run on them as is extracted. By default this > > > option is off, but is enabled in the event that fips mode is selected during > > > bootup. > > > > > > Neil > > > > > > Signed-off-by: Neil Horman > > > > > Ping, I don't see that this got picked up in the crypto tree. Are there > > subsequent objections? > > Matt, are you OK with me picking this up or do you want to pick it > up? Acked-by: Matt Mackall You can pick it up. Speaking of, do you care if I route other RNG bits through your crypto tree? I usually just bounce patches to Andrew. -- http://selenic.com : development and support for Mercurial and Linux