From: Sebastian Andrzej Siewior Subject: Re: [PATCH] crypto: Update stdrng test name so that the testmgr finds it properly Date: Thu, 2 Jul 2009 08:42:21 +0200 Message-ID: <20090702064221.GA18935@Chamillionaire.breakpoint.cc> References: <20090701155219.GA31414@hmsreliant.think-freely.org> <20090702060255.GA18642@Chamillionaire.breakpoint.cc> Reply-To: Sebastian Andrzej Siewior Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Cc: linux-crypto@vger.kernel.org, herbert@gondor.apana.org.au, davem@davemloft.net To: Neil Horman Return-path: Received: from Chamillionaire.breakpoint.cc ([85.10.199.196]:34006 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750946AbZGBGmT (ORCPT ); Thu, 2 Jul 2009 02:42:19 -0400 Content-Disposition: inline In-Reply-To: <20090702060255.GA18642@Chamillionaire.breakpoint.cc> Sender: linux-crypto-owner@vger.kernel.org List-ID: * Sebastian Andrzej Siewior | 2009-07-02 08:02:55 [+0200]: >* Neil Horman | 2009-07-01 11:52:19 [-0400]: > >>index f9bea9d..3315a38 100644 >>--- a/crypto/testmgr.c >>+++ b/crypto/testmgr.c >>@@ -1480,7 +1480,7 @@ static int alg_test_cprng(const struct alg_test_desc *desc, const char *driver, >> /* Please keep this list sorted by algorithm name. */ >> static const struct alg_test_desc alg_test_descs[] = { >> { >>- .alg = "ansi_cprng", >>+ .alg = "stdrng", >> .test = alg_test_cprng, >> .fips_allowed = 1, >> .suite = { > >Don't you use this vector for _all_ stdrngs now? krng for instance will >fail. This is wrong anyway because the alg field has to be sorted alphabetically due to the nature of the search function. Sebastian