From: Steffen Klassert Subject: Re: [PATCH v2] crypto: authenc - convert to ahash Date: Tue, 21 Jul 2009 15:23:09 +0200 Message-ID: <20090721132309.GH20288@secunet.com> References: <20090721090217.GF20288@secunet.com> <20090721122509.GG20288@secunet.com> <20090721130725.GA19550@gondor.apana.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-crypto@vger.kernel.org To: Herbert Xu Return-path: Received: from a.mx.secunet.com ([213.68.205.161]:34337 "EHLO a.mx.secunet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754380AbZGUNUg (ORCPT ); Tue, 21 Jul 2009 09:20:36 -0400 Content-Disposition: inline In-Reply-To: <20090721130725.GA19550@gondor.apana.org.au> Sender: linux-crypto-owner@vger.kernel.org List-ID: On Tue, Jul 21, 2009 at 09:07:25PM +0800, Herbert Xu wrote: > On Tue, Jul 21, 2009 at 02:25:09PM +0200, Steffen Klassert wrote: > > I just noticed that your shash version of hmac keeps the paded keys > > on the transform. I assumed the hashing to be reentrant, so I > > removed the locks arround the hash functions here. > > The padded keys are in the transform because they never change > unless you call setkey. The assumption has always been that > you should use one tfm per key. Ah, yes of course. > > > Is there a plan to move the paded keys to the request soon, > > or should we keep the locks for now and remove them later? > > You don't need to lock it since the same assumption applies to > AEAD. > I came on it because I applied the pcrypt patches on top of this one and I had to put the locks arround the hash functions to get it to work. The problem is probaply somewhere else, I'll look at it again.