From: Steffen Klassert Subject: Re: [PATCH v2] crypto: authenc - convert to ahash Date: Wed, 22 Jul 2009 09:32:11 +0200 Message-ID: <20090722073211.GI20288@secunet.com> References: <20090721090217.GF20288@secunet.com> <20090722070259.GA29808@gondor.apana.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-crypto@vger.kernel.org To: Herbert Xu Return-path: Received: from a.mx.secunet.com ([213.68.205.161]:40406 "EHLO a.mx.secunet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752524AbZGVH3f (ORCPT ); Wed, 22 Jul 2009 03:29:35 -0400 Content-Disposition: inline In-Reply-To: <20090722070259.GA29808@gondor.apana.org.au> Sender: linux-crypto-owner@vger.kernel.org List-ID: On Wed, Jul 22, 2009 at 03:02:59PM +0800, Herbert Xu wrote: > On Tue, Jul 21, 2009 at 11:02:17AM +0200, Steffen Klassert wrote: > > > > + err = crypto_ahash_finup(ahreq); > > + if (err == -EINPROGRESS) > > + return; > > This is redundant. All completion functions must expect to be > called with EINPROGRESS followed by the actual completion later. I copied this from crypto_authenc_encrypt_done(), so this is probaply redundant too. If so, I'd send a patch to remove the already existing checks too and put the updated ahash convertion patch on top of it.