From: Herbert Xu Subject: Re: [PATCH] linux/kernel.h, linux/mm.h, linux/slab.h are not needed in crypto/*.c Date: Sat, 22 Aug 2009 13:38:18 +1000 Message-ID: <20090822033818.GA16795@gondor.apana.org.au> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: squadette@gmail.com, linux-crypto@vger.kernel.org To: Geert Uytterhoeven Return-path: Received: from rhun.apana.org.au ([64.62.148.172]:58414 "EHLO arnor.apana.org.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933219AbZHVDiY (ORCPT ); Fri, 21 Aug 2009 23:38:24 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-crypto-owner@vger.kernel.org List-ID: Geert Uytterhoeven wrote: > > Have you compile-tested this on (all?) architectures (note I didn't). > But usually some of the includes you removed may be included indirectly on some > platforms, but not on all of them. Indeed, this patch looks completely broken. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt