From: Catalin Marinas Subject: Re: [PATCH] arm: new W macro to WORD_ACCESS Date: Wed, 16 Sep 2009 21:59:27 +0100 Message-ID: <1253134767.19743.3.camel@pc1117.cambridge.arm.com> References: <200909161601.35662.elendil@planet.nl> <20090916175812.GA18993@Chamillionaire.breakpoint.cc> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: Frans Pop , linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, Herbert Xu , linux-arm-kernel@lists.infradead.org, Alexey Dobriyan To: Sebastian Andrzej Siewior Return-path: Received: from cam-admin0.cambridge.arm.com ([193.131.176.58]:53072 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754808AbZIPVDo (ORCPT ); Wed, 16 Sep 2009 17:03:44 -0400 In-Reply-To: <20090916175812.GA18993@Chamillionaire.breakpoint.cc> Sender: linux-crypto-owner@vger.kernel.org List-ID: On Wed, 2009-09-16 at 19:58 +0200, Sebastian Andrzej Siewior wrote: > As reported by Frans Pop the new global macro W on ARM which is included > via > |arch/arm/include/asm/uaccess.h:20 > |include/linux/uaccess.h:5 > |include/linux/crypto.h:26 > |crypto/cast6.c:23 > > leads to a build error because the crypto/cast6.c defines a function > which is named W. This was already reported by Alexey Dobriyan and I included his patch in my Thumb-2 branch (and -next for now): http://linux-arm.org/git?p=linux-2.6.git;a=commitdiff;h=4fb3c2e2ab3549308a1b1663296d165e45d72ba5 Since this macro is only used in ARM assembly code, the patch simply adds some ifdefs around it. Russell, if you are OK with Alexey's patch, I'll send you a pull request (though for only one patch, alternatively just merge it manually). -- Catalin