From: Joe Perches Subject: [PATCH 00/21] pr_dbg, pr_fmt Date: Sun, 4 Oct 2009 17:53:27 -0700 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: x86@kernel.org, kvm@vger.kernel.org, Frederic Weisbecker , Andreas Herrmann , "H. Peter Anvin" , Samuel Chessman , Thomas Gleixner , Herbert Xu , Jay Vosburgh , bonding-devel@lists.sourceforge.net, Ingo Molnar , Avi Kivity , linux-crypto@vger.kernel.org, Len Brown , amd64-microcode@amd64.org, Joerg Roedel , Maciej Sosnowski , Steven Rostedt , Marcelo Tosatti , linux-pm@li.sts.linux-foundation.org, Dan Williams , netdev@vger.kernel.org, Tigran Aivazian To: linux-kernel@vger.kernel.org Return-path: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-pm-bounces@lists.linux-foundation.org Errors-To: linux-pm-bounces@lists.linux-foundation.org List-Id: linux-crypto.vger.kernel.org One possible long term goal is to stop adding #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt to source files to prefix modulename to logging output. It might be useful to eventually have kernel.h use a standard #define pr_fmt which includes KBUILD_MODNAME instead of a blank or empty define. Perhaps over time, the source modules that use pr_ with prefixes can be converted to use pr_fmt. If all modules are converted, that will allow the printk routine to add module/filename/line/offset to the logging lines using some function similar to dynamic_debug and substantially reduct object string use by removing the repeated prefixes. This patchset does not get to that result. The patches right now uses _more_ string space because all logging messages have unshared prefixes but it may be a useful start. The patchset strips prefixes from printks and adds pr_fmt to arch/x86, crypto, kernel, and a few drivers. It also converts printk(KERN_ to pr_ in a few files that already had some pr_ uses. The conversion also generally used long length format strings in the place of multiple short strings to ease any grep/search. Joe Perches (21): include/linux/ dynamic_debug.h kernel.h: Remove KBUILD_MODNAME from dynamic_pr_debug, add #define pr_dbg ftrace.c: Add #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt mtrr: use pr_ and pr_fmt microcode: use pr_ and add pr_fmt amd_iommu.c: use pr_ and add pr_fmt(fmt) es7000_32.c: use pr_ and add pr_fmt(fmt) arch/x86/kernel/apic/: use pr_ and add pr_fmt(fmt) mcheck/: use pr_ and add pr_fmt(fmt) arch/x86/kernel/setup_percpu.c: use pr_ and add pr_fmt(fmt) arch/x86/kernel/cpu/: use pr_ and add pr_fmt(fmt) i8254.c: Add pr_fmt(fmt) kmmio.c: Add and use pr_fmt(fmt) testmmiotrace.c: Add and use pr_fmt(fmt) crypto/: use pr_ and add pr_fmt(fmt) kernel/power/: use pr_ and add pr_fmt(fmt) kernel/kexec.c: use pr_ and add pr_fmt(fmt) crypto/async_tx/raid6test.c: use pr_ and add pr_fmt(fmt) arch/x86/mm/mmio-mod.c: use pr_fmt drivers/net/bonding/: : use pr_fmt drivers/net/tlan: use pr_ and add pr_fmt(fmt) drivers/net/tlan.h: Convert printk(KERN_DEBUG to pr_dbg( arch/x86/kernel/amd_iommu.c | 71 ++-- arch/x86/kernel/apic/apic.c | 48 ++-- arch/x86/kernel/apic/apic_flat_64.c | 5 +- arch/x86/kernel/apic/bigsmp_32.c | 8 +- arch/x86/kernel/apic/es7000_32.c | 12 +- arch/x86/kernel/apic/io_apic.c | 239 ++++++------ arch/x86/kernel/apic/nmi.c | 29 +- arch/x86/kernel/apic/numaq_32.c | 53 ++-- arch/x86/kernel/apic/probe_32.c | 18 +- arch/x86/kernel/apic/probe_64.c | 8 +- arch/x86/kernel/apic/summit_32.c | 23 +- arch/x86/kernel/apic/x2apic_uv_x.c | 26 +- arch/x86/kernel/cpu/addon_cpuid_features.c | 9 +- arch/x86/kernel/cpu/amd.c | 26 +- arch/x86/kernel/cpu/bugs.c | 23 +- arch/x86/kernel/cpu/bugs_64.c | 4 +- arch/x86/kernel/cpu/centaur.c | 12 +- arch/x86/kernel/cpu/common.c | 54 ++-- arch/x86/kernel/cpu/cpu_debug.c | 4 +- arch/x86/kernel/cpu/cyrix.c | 12 +- arch/x86/kernel/cpu/intel.c | 14 +- arch/x86/kernel/cpu/intel_cacheinfo.c | 14 +- arch/x86/kernel/cpu/mcheck/mce-inject.c | 20 +- arch/x86/kernel/cpu/mcheck/mce.c | 59 ++-- arch/x86/kernel/cpu/mcheck/mce_intel.c | 8 +- arch/x86/kernel/cpu/mcheck/p5.c | 21 +- arch/x86/kernel/cpu/mcheck/therm_throt.c | 21 +- arch/x86/kernel/cpu/mcheck/threshold.c | 7 +- arch/x86/kernel/cpu/mcheck/winchip.c | 8 +- arch/x86/kernel/cpu/mtrr/centaur.c | 4 +- arch/x86/kernel/cpu/mtrr/cleanup.c | 59 ++-- arch/x86/kernel/cpu/mtrr/generic.c | 39 +- arch/x86/kernel/cpu/mtrr/main.c | 32 +- arch/x86/kernel/cpu/perf_event.c | 10 +- arch/x86/kernel/cpu/perfctr-watchdog.c | 11 +- arch/x86/kernel/cpu/transmeta.c | 20 +- arch/x86/kernel/cpu/vmware.c | 11 +- arch/x86/kernel/ftrace.c | 8 +- arch/x86/kernel/microcode_amd.c | 5 +- arch/x86/kernel/microcode_core.c | 23 +- arch/x86/kernel/microcode_intel.c | 47 +-- arch/x86/kernel/setup_percpu.c | 13 +- arch/x86/kvm/i8254.c | 12 +- arch/x86/mm/kmmio.c | 40 +- arch/x86/mm/mmio-mod.c | 71 ++-- arch/x86/mm/testmmiotrace.c | 29 +- crypto/algapi.c | 4 +- crypto/ansi_cprng.c | 39 +- crypto/async_tx/async_tx.c | 5 +- crypto/async_tx/raid6test.c | 30 +- crypto/fips.c | 4 +- crypto/tcrypt.c | 75 ++-- crypto/testmgr.c | 286 ++++++-------- crypto/xor.c | 17 +- drivers/net/bonding/bond_3ad.c | 171 +++++---- drivers/net/bonding/bond_alb.c | 38 +-- drivers/net/bonding/bond_ipv6.c | 12 +- drivers/net/bonding/bond_main.c | 608 +++++++++++----------------- drivers/net/bonding/bond_sysfs.c | 322 ++++++--------- drivers/net/tlan.c | 135 +++--- drivers/net/tlan.h | 2 +- include/linux/dynamic_debug.h | 13 +- include/linux/kernel.h | 7 +- kernel/kexec.c | 21 +- kernel/power/hibernate.c | 46 +-- kernel/power/hibernate_nvs.c | 6 +- kernel/power/process.c | 29 +- kernel/power/snapshot.c | 36 +- kernel/power/suspend.c | 18 +- kernel/power/suspend_test.c | 18 +- kernel/power/swap.c | 42 +- kernel/power/swsusp.c | 10 +- kernel/power/user.c | 8 +- 73 files changed, 1543 insertions(+), 1749 deletions(-)