From: Herbert Xu Subject: Re: [PATCH] crypto: Fix test in get_prng_bytes() Date: Mon, 12 Oct 2009 23:07:53 +0900 Message-ID: <20091012140753.GA30300@gondor.apana.org.au> References: <4AD32A75.5030706@gmail.com> <20091012135142.GB8885@hmsreliant.think-freely.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Roel Kluin , "David S. Miller" , linux-crypto@vger.kernel.org, Andrew Morton To: Neil Horman Return-path: Received: from rhun.apana.org.au ([64.62.148.172]:52371 "EHLO arnor.apana.org.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932201AbZJLOIl (ORCPT ); Mon, 12 Oct 2009 10:08:41 -0400 Content-Disposition: inline In-Reply-To: <20091012135142.GB8885@hmsreliant.think-freely.org> Sender: linux-crypto-owner@vger.kernel.org List-ID: On Mon, Oct 12, 2009 at 09:51:42AM -0400, Neil Horman wrote: . > > Or should this test be removed? > > > > diff --git a/crypto/ansi_cprng.c b/crypto/ansi_cprng.c > > index 3aa6e38..9162456 100644 > > --- a/crypto/ansi_cprng.c > > +++ b/crypto/ansi_cprng.c > > @@ -192,7 +192,7 @@ static int get_prng_bytes(char *buf, size_t nbytes, struct prng_context *ctx) > > int err; > > > > > > - if (nbytes < 0) > > + if ((ssize_t)nbytes < 0) > > return -EINVAL; > > > > spin_lock_bh(&ctx->prng_lock); > No, you're quite right, its a harmless, but unneeded check. Herbert, could you > pull this into cryptodev please? Thank you. Hmm, if it's unneeded why don't we just kill it instead? Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt