From: Ingo Molnar Subject: Re: [PATCH 1/2] x86, crypto, Generate .byte code for some new instructions via gas macro Date: Sun, 8 Nov 2009 11:56:19 +0100 Message-ID: <20091108105619.GF11372@elte.hu> References: <1257403455.22519.249.camel@yhuang-dev.sh.intel.com> <20091105142336.GB1910@gondor.apana.org.au> <4AF30447.2030705@zytor.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Herbert Xu , Huang Ying , "linux-kernel@vger.kernel.org" , "linux-crypto@vger.kernel.org" To: "H. Peter Anvin" Return-path: Received: from mx2.mail.elte.hu ([157.181.151.9]:41229 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751118AbZKHK4X (ORCPT ); Sun, 8 Nov 2009 05:56:23 -0500 Content-Disposition: inline In-Reply-To: <4AF30447.2030705@zytor.com> Sender: linux-crypto-owner@vger.kernel.org List-ID: * H. Peter Anvin wrote: > On 11/05/2009 06:23 AM, Herbert Xu wrote: > > On Thu, Nov 05, 2009 at 02:44:15PM +0800, Huang Ying wrote: > >> It will take some time for binutils (gas) to support some newly added > >> instructions, such as SSE4.1 instructions or the AES-NI instructions > >> found in upcoming Intel CPU. > >> > >> To make the source code can be compiled by old binutils, .byte code is > >> used instead of the assembly instruction. But the readability and > >> flexibility of raw .byte code is not good. > >> > >> This patch solves the issue of raw .byte code via generating it via > >> assembly instruction like gas macro. The syntax is as close as > >> possible to real assembly instruction. > >> > >> Some helper macros such as MODRM is not a full feature > >> implementation. It can be extended when necessary. > >> > >> Signed-off-by: Huang Ying > > > > Once Ingo acks this I'll throw it into cryptodev. > > > > I'm not Ingo, but: > > Acked-by: H. Peter Anvin Fine to me too and for future variations thereof. Ingo