From: Sebastian Andrzej Siewior Subject: Re: Bug in geode-aes.c ? Date: Thu, 12 Nov 2009 10:18:07 +0100 Message-ID: <20091112091807.GC22434@Chamillionaire.breakpoint.cc> References: <20091111220832.GC18452@Chamillionaire.breakpoint.cc> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Cc: linux-crypto@vger.kernel.org, Herbert Xu To: Sergey Mironov Return-path: Received: from Chamillionaire.breakpoint.cc ([85.10.199.196]:39340 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751103AbZKLJSC (ORCPT ); Thu, 12 Nov 2009 04:18:02 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-crypto-owner@vger.kernel.org List-ID: >From 0a61b446585324a3041ef0a138515ef936a14eb7 Mon Sep 17 00:00:00 2001 >From: Sergey Mironov >Date: Thu, 12 Nov 2009 11:30:02 +0300 >Subject: [PATCH] Fixed typo bugs in geod-aes.c On a second look could you please add something like: crypto/geode: access fallback.cip cipher fallback mode |The fallback code in cipher mode touch the union fallback.blk instead |of fallback.cip. This is wrong because we use the cipher and not the |blockcipher. This did not show any side effects yet because both types / |structs contain the same element right now. >Signed-off-by: Sergey Mironov >--- > drivers/crypto/geode-aes.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > >diff --git a/drivers/crypto/geode-aes.c b/drivers/crypto/geode-aes.c >index 4801162..03e71b1 100644 >--- a/drivers/crypto/geode-aes.c >+++ b/drivers/crypto/geode-aes.c >@@ -135,8 +135,8 @@ static int geode_setkey_cip(struct crypto_tfm >*tfm, const u8 *key, > /* > * The requested key size is not supported by HW, do a fallback > */ >- op->fallback.blk->base.crt_flags &= ~CRYPTO_TFM_REQ_MASK; >- op->fallback.blk->base.crt_flags |= (tfm->crt_flags & CRYPTO_TFM_REQ_MASK); >+ op->fallback.cip->base.crt_flags &= ~CRYPTO_TFM_REQ_MASK; >+ op->fallback.cip->base.crt_flags |= (tfm->crt_flags & CRYPTO_TFM_REQ_MASK); > > ret = crypto_cipher_setkey(op->fallback.cip, key, len); > if (ret) { >@@ -263,7 +263,7 @@ static int fallback_init_cip(struct crypto_tfm *tfm) > > if (IS_ERR(op->fallback.cip)) { > printk(KERN_ERR "Error allocating fallback algo %s\n", name); >- return PTR_ERR(op->fallback.blk); >+ return PTR_ERR(op->fallback.cip); > } > > return 0; Sebastian