From: Krzysztof Halasa Subject: Re: Crypto test results unused? Date: Mon, 28 Dec 2009 20:44:20 +0100 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: lkml To: linux-crypto@vger.kernel.org Return-path: Received: from khc.piap.pl ([195.187.100.11]:47918 "EHLO khc.piap.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750892AbZL1ToZ (ORCPT ); Mon, 28 Dec 2009 14:44:25 -0500 In-Reply-To: (Krzysztof Halasa's message of "Mon, 28 Dec 2009 19:12:50 +0100") Sender: linux-crypto-owner@vger.kernel.org List-ID: > int crypto_register_alg(struct crypto_alg *alg) > { > struct crypto_larval *larval; > int err; > > err = crypto_check_alg(alg); > if (err) > return err; > > down_write(&crypto_alg_sem); > larval = __crypto_register_alg(alg); > up_write(&crypto_alg_sem); > > if (IS_ERR(larval)) > return PTR_ERR(larval); > > crypto_wait_for_test(larval); > > At this point alg->cra_flags includes CRYPTO_ALG_DEAD (due to failed > test), but larval->alg.cra_flags has only the original flags (0x85). Actually it seems all alg->cra_flags are CRYPTO_ALG_DEAD at this point, not only these which failed tests. Will look at it soon. -- Krzysztof Halasa