From: Herbert Xu Subject: Re: [PATCH] dm-crypt: disable block encryption with arc4 Date: Tue, 9 Feb 2010 18:37:18 +1100 Message-ID: <20100209073718.GA17612@gondor.apana.org.au> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: mbroz@redhat.com, linux-crypto@ml.breakpoint.cc, dm-devel@redhat.com, agk@redhat.com, linux-crypto@vger.kernel.org To: Mikulas Patocka Return-path: Received: from rhun.apana.org.au ([64.62.148.172]:52628 "EHLO arnor.apana.org.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752473Ab0BIHhZ (ORCPT ); Tue, 9 Feb 2010 02:37:25 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-crypto-owner@vger.kernel.org List-ID: Mikulas Patocka wrote: > > You should rather add a flag CRYPTO_ALG_CHANGES_STATE to determine that a > cipher can't be used to encrypt disks. No, please see my reply in the previous thread. What we should do is fix arc4. I just haven't got around to doing it yet. As to blacklisting algorithms not suitable for disk encryption, that is up to the dm-crypt maintainers to decide. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt