From: Steffen Klassert Subject: Re: [patch] pcrypt: handle crypto_get_attr_type() errors Date: Mon, 22 Mar 2010 14:23:42 +0100 Message-ID: <20100322132342.GJ20508@secunet.com> References: <20100321092847.GJ5331@bicker> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii To: Dan Carpenter , Herbert Xu , "David S. Miller" , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, kern Return-path: Received: from a.mx.secunet.com ([213.68.205.161]:60577 "EHLO a.mx.secunet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751884Ab0CVNVl (ORCPT ); Mon, 22 Mar 2010 09:21:41 -0400 Content-Disposition: inline In-Reply-To: <20100321092847.GJ5331@bicker> Sender: linux-crypto-owner@vger.kernel.org List-ID: On Sun, Mar 21, 2010 at 12:28:47PM +0300, Dan Carpenter wrote: > crypto_get_attr_type() can returns ERR_PTRs if there is a problem. > > Signed-off-by: Dan Carpenter > > diff --git a/crypto/pcrypt.c b/crypto/pcrypt.c > index 8020124..41bd80f 100644 > --- a/crypto/pcrypt.c > +++ b/crypto/pcrypt.c > @@ -322,6 +322,8 @@ static struct crypto_instance *pcrypt_alloc_aead(struct rtattr **tb) > struct crypto_attr_type *algt; > > algt = crypto_get_attr_type(tb); > + if (IS_ERR(algt)) > + return ERR_CAST(algt); > > alg = crypto_get_attr_alg(tb, algt->type, > (algt->mask & CRYPTO_ALG_TYPE_MASK)); I've just noticed that we are calling crypto_get_attr_type already in pcrypt_alloc, so perhaps we could just pass the type and mask to pcrypt_alloc_aead. Then we can remove this second call to crypto_get_attr_type completely. Steffen