From: Herbert Xu Subject: Re: [PATCHv3 2/2] crypto: omap-sham - omap sha1 & md5 driver Date: Wed, 14 Apr 2010 14:20:52 +0800 Message-ID: <20100414062052.GA20395@gondor.apana.org.au> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: tony@atomide.com, linux-crypto@vger.kernel.org, linux-omap@vger.kernel.org To: Dmitry Kasatkin Return-path: Received: from ringil.hengli.com.au ([216.59.3.182]:38419 "EHLO arnor.apana.org.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753469Ab0DNGU6 (ORCPT ); Wed, 14 Apr 2010 02:20:58 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-crypto-owner@vger.kernel.org List-ID: Dmitry Kasatkin wrote: > Earlier kernel contained omap sha1 and md5 driver, which was not maintained, > was not ported to new crypto APIs and removed from the source tree. > > - implements async and sync crypto API using dma and cpu. > - supports multiple sham instances if available > > Signed-off-by: Dmitry Kasatkin You have not addressed my objections raised earlier. Also, why are you exporting a shash object? You cannot sleep during shash operations (except for setkey). Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt