From: Dmitry Kasatkin Subject: Re: [PATCHv3 2/2] crypto: omap-sham - omap sha1 & md5 driver Date: Wed, 14 Apr 2010 09:41:28 +0300 Message-ID: <4BC56398.40500@nokia.com> References: <20100414062052.GA20395@gondor.apana.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "linux-crypto@vger.kernel.org" , "linux-omap@vger.kernel.org" To: ext Herbert Xu Return-path: In-Reply-To: <20100414062052.GA20395@gondor.apana.org.au> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-crypto.vger.kernel.org On 14/04/10 09:20, ext Herbert Xu wrote: > Dmitry Kasatkin wrote: > >> Earlier kernel contained omap sha1 and md5 driver, which was not maintained, >> was not ported to new crypto APIs and removed from the source tree. >> >> - implements async and sync crypto API using dma and cpu. >> - supports multiple sham instances if available >> >> Signed-off-by: Dmitry Kasatkin >> > You have not addressed my objections raised earlier. > > Also, why are you exporting a shash object? You cannot sleep during > shash operations (except for setkey). > > what do you mean "exporting shash object"? Providing shash alg? I was not sure if it is needed if ahash is available. Should I remove shash alg at all? > Cheers, >