From: Tony Lindgren Subject: Re: [PATCH 1/1] omap-sham: OMAP macros corrected Date: Mon, 10 May 2010 10:03:29 -0700 Message-ID: <20100510170328.GD16460@atomide.com> References: <948fcc79dd3d31f4930d4b62bb7ca7a19949fd9a.1273493232.git.dmitry.kasatkin@nokia.com> <20100510121416.GA12769@gondor.apana.org.au> <4BE800F3.2070602@nokia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: ext Herbert Xu , "linux-crypto@vger.kernel.org" , "linux-omap@vger.kernel.org" To: Dmitry Kasatkin Return-path: Content-Disposition: inline In-Reply-To: <4BE800F3.2070602@nokia.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-crypto.vger.kernel.org * Dmitry Kasatkin [100510 05:45]: > > On 10/05/10 15:14, ext Herbert Xu wrote: > > On Mon, May 10, 2010 at 03:07:55PM +0300, Dmitry Kasatkin wrote: > > > >> Signed-off-by: Dmitry Kasatkin > >> --- > >> arch/arm/mach-omap2/devices.c | 4 ++-- > >> 1 files changed, 2 insertions(+), 2 deletions(-) > >> > >> diff --git a/arch/arm/mach-omap2/devices.c b/arch/arm/mach-omap2/devices.c > >> index beac46c..79dbf04 100644 > >> --- a/arch/arm/mach-omap2/devices.c > >> +++ b/arch/arm/mach-omap2/devices.c > >> @@ -456,7 +456,7 @@ static inline void omap_init_mcspi(void) {} > >> > >> #if defined(CONFIG_CRYPTO_DEV_OMAP_SHAM) || defined(CONFIG_CRYPTO_DEV_OMAP_SHAM_MODULE) > >> > >> -#ifdef CONFIG_ARCH_OMAP24XX > >> +#ifdef CONFIG_ARCH_OMAP2 > >> static struct resource omap2_sham_resources[] = { > >> { > >> .start = OMAP24XX_SEC_SHA1MD5_BASE, > >> @@ -474,7 +474,7 @@ static int omap2_sham_resources_sz = ARRAY_SIZE(omap2_sham_resources); > >> #define omap2_sham_resources_sz 0 > >> #endif > >> > >> -#ifdef CONFIG_ARCH_OMAP34XX > >> +#ifdef CONFIG_ARCH_OMAP3 > >> static struct resource omap3_sham_resources[] = { > >> { > >> .start = OMAP34XX_SEC_SHA1MD5_BASE, > >> > > Hi Tony: > > > > If I add this patch to cryptodev, is this going to cause any > > problems for you? > > > > Thbanks, > > > Hi, > > I should not be any problem, because it indeed needs to be like that. Yeah please go ahead and add it. If we run into merge problems with devices.c, we move some patches into omap for-next branch. Acked-by: Tony Lindgren