From: Adrian-Ken Rueegsegger Subject: Re: [BUG] SLOB breaks Crypto Date: Mon, 17 May 2010 23:50:06 +0200 Message-ID: <4BF1BA0E.4010402@codelabs.ch> References: <4B9E38AF.70309@fami-braun.de> <84144f021003180930s44e239dfmb38183096f07c8a8@mail.gmail.com> <4BA29A19.2050307@fami-braun.de> <20100319003351.GC20227@gondor.apana.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Herbert Xu , michael-dev@fami-braun.de, Pekka Enberg , linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, Matt Mackall , Atsushi Nemoto To: Geert Uytterhoeven Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-crypto.vger.kernel.org Geert Uytterhoeven wrote: > On Fri, Mar 19, 2010 at 02:33, Herbert Xu wrote: >> On Thu, Mar 18, 2010 at 10:24:41PM +0100, michael-dev@fami-braun.de wrote: >>> Pekka Enberg schrieb: >>>> Even with CONFIG_DEBUG_SLAB enabled or with CONFIG_SLUB and >>>> CONFIG_SLUB_DEBUG_ON? >>> no, these options have not been / are not enabled. >> Can you please try it with those options enabled? That will tell >> us if there is some latent bug in the crypto layer that only shows >> up right away under SLOB. > > After seeing a posting from Nemoto-san on the linux-mips list (should > show up soon on > http://www.linux-mips.org/archives/linux-mips/2010-05/threads.html), > I'm wondering if these defaults are the culprit; > > mm/slab.c:#define ARCH_KMALLOC_MINALIGN __alignof__(unsigned long long) > mm/slob.c:#define ARCH_KMALLOC_MINALIGN __alignof__(unsigned long) > mm/slub.c:#define ARCH_KMALLOC_MINALIGN __alignof__(unsigned long long) Just a quick note: I changed this line in mm/slob.c to (unsigned long long) and was able to load tcrypt without the kernel oopsing or panic'ing. When running all test via modprobe tcrypt the tests seem to pass fine judging by /proc/crypto. Nevertheless module insertion fails (as expected) but does not return EAGAIN but EMULTIHOP instead... Regards, Adrian