From: Pekka Enberg Subject: Re: [BUG] SLOB breaks Crypto Date: Wed, 19 May 2010 00:15:46 +0300 Message-ID: References: <20100518102701.GA7293@gondor.apana.org.au> <20100518.122512.73694279.davem@davemloft.net> <1274211235.11603.1205.camel@calx> <20100518.135945.180391159.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Cc: mpm@selenic.com, herbert@gondor.apana.org.au, ken@codelabs.ch, geert@linux-m68k.org, michael-dev@fami-braun.de, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, anemo@mba.ocn.ne.jp To: David Miller Return-path: Received: from mail-fx0-f46.google.com ([209.85.161.46]:56007 "EHLO mail-fx0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754731Ab0ERVPu (ORCPT ); Tue, 18 May 2010 17:15:50 -0400 In-Reply-To: <20100518.135945.180391159.davem@davemloft.net> Sender: linux-crypto-owner@vger.kernel.org List-ID: Hi David, On Tue, May 18, 2010 at 11:59 PM, David Miller wrote: > From: Matt Mackall > Date: Tue, 18 May 2010 14:33:55 -0500 > >> SLOB honors ARCH_KMALLOC_MINALIGN. If your arch has alignment >> requirements, I recommend you set it. > > I recommend that the alignment provided by the allocator is not > determined by which allocator I happen to have enabled. > > The values and ifdef'ery should be identical in all of our > allocators. Why? It doesn't make much sense for SLOB, which tries to be as space efficient as possible, as a default. If things break on sparc, it really needs to set ARCH_KMALLOC_MINALIGN as slab default alignment is not something you really want to depend on. Pekka