From: Herbert Xu Subject: Re: [BUG] SLOB breaks Crypto Date: Wed, 19 May 2010 11:05:24 +1000 Message-ID: <20100519010524.GB18813@gondor.apana.org.au> References: <1274211235.11603.1205.camel@calx> <20100518.135945.180391159.davem@davemloft.net> <20100518.142021.135951273.davem@davemloft.net> <1274224834.6930.8361.camel@macbook.infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: David Miller , penberg@cs.helsinki.fi, mpm@selenic.com, ken@codelabs.ch, geert@linux-m68k.org, michael-dev@fami-braun.de, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, anemo@mba.ocn.ne.jp To: David Woodhouse Return-path: Content-Disposition: inline In-Reply-To: <1274224834.6930.8361.camel@macbook.infradead.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-crypto.vger.kernel.org On Wed, May 19, 2010 at 12:20:34AM +0100, David Woodhouse wrote: > > It would be better if the minimum alignment was exposed to generic code > though -- you're right that the CPP tests in linux/crypto.h really > shouldn't have to exist. If it wasn't for that, then the crypto problem > wouldn't have occurred. While this problem wouldn't have occurred, we would instead have data corruption/alignment faults on architectures such as sparc32 or ARM that require 64-bit alignment for 64-bit objects. So no getting rid of them isn't going to fix things either. Of course I have no objections to moving this into slab.h or a similar location should anyone be willing to do the hard work. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt