From: Geert Uytterhoeven Subject: Re: [BUG] SLOB breaks Crypto Date: Wed, 19 May 2010 13:32:41 +0200 Message-ID: References: <1274211235.11603.1205.camel@calx> <20100518.135945.180391159.davem@davemloft.net> <20100518.142021.135951273.davem@davemloft.net> <1274224834.6930.8361.camel@macbook.infradead.org> <20100519010524.GB18813@gondor.apana.org.au> <1274253269.6930.9325.camel@macbook.infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Cc: Herbert Xu , David Miller , penberg@cs.helsinki.fi, mpm@selenic.com, ken@codelabs.ch, michael-dev@fami-braun.de, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, anemo@mba.ocn.ne.jp To: David Woodhouse Return-path: Received: from mail-wy0-f174.google.com ([74.125.82.174]:58308 "EHLO mail-wy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753364Ab0ESLkw (ORCPT ); Wed, 19 May 2010 07:40:52 -0400 In-Reply-To: <1274253269.6930.9325.camel@macbook.infradead.org> Sender: linux-crypto-owner@vger.kernel.org List-ID: On Wed, May 19, 2010 at 09:14, David Woodhouse wrote: > On Wed, 2010-05-19 at 11:05 +1000, Herbert Xu wrote: >> While this problem wouldn't have occurred, we would instead have >> data corruption/alignment faults on architectures such as sparc32 >> or ARM that require 64-bit alignment for 64-bit objects. > > Yeah, but that's what ARCH_SLAB_MINALIGN is for. > > ARM gets this right, and Dave has already said he's going to fix sparc. Instead of having (different) defaults in sl[aou]b, perhaps we should just remove the defaults completely, to ensure all architectures set ARCH_SLAB_MINALIGN to the correct value? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds