From: Herbert Xu Subject: Re: [BUG] SLOB breaks Crypto Date: Wed, 19 May 2010 21:46:09 +1000 Message-ID: <20100519114609.GA26610@gondor.apana.org.au> References: <1274211235.11603.1205.camel@calx> <20100518.135945.180391159.davem@davemloft.net> <20100518.142021.135951273.davem@davemloft.net> <1274224834.6930.8361.camel@macbook.infradead.org> <20100519010524.GB18813@gondor.apana.org.au> <1274266725.6930.9823.camel@macbook.infradead.org> <1274267805.6930.9877.camel@macbook.infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Pekka Enberg , David Miller , mpm@selenic.com, ken@codelabs.ch, geert@linux-m68k.org, michael-dev@fami-braun.de, linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org, anemo@mba.ocn.ne.jp To: David Woodhouse Return-path: Received: from ringil.hengli.com.au ([216.59.3.182]:46782 "EHLO arnor.apana.org.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754021Ab0ESLqm (ORCPT ); Wed, 19 May 2010 07:46:42 -0400 Content-Disposition: inline In-Reply-To: <1274267805.6930.9877.camel@macbook.infradead.org> Sender: linux-crypto-owner@vger.kernel.org List-ID: On Wed, May 19, 2010 at 12:16:45PM +0100, David Woodhouse wrote: > > I don't mind. Feel free to apply them to slab.git, but be aware that > Herbert wanted to see a patch fixing sparc32 ARCH_SLAB_MINALIGN before > the crypto one is applied. > > Although arguably SLOB was broken on sparc32 even before the crypto > patch -- so perhaps that fix shouldn't _have_ to go in first? Well prior to this crypto on sparc32 did work with SLAB/SLUB. If you change it without including the sparc pach, then sparc32 would be broken regardless of which allocator you used. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt