From: "Justin P. Mattock" Subject: Re: [PATCH]crypto:hifn_795x.c Fix warning: variable 'ctx' set but not used Date: Tue, 06 Jul 2010 06:46:49 -0700 Message-ID: <4C3333C9.8000206@gmail.com> References: <20100706070355.GA14626@gondor.apana.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: linux-crypto@vger.kernel.org, davem@davemloft.net, jkosina@suse.cz, linux-kernel@vger.kernel.org To: Herbert Xu Return-path: Received: from mail-pv0-f174.google.com ([74.125.83.174]:34175 "EHLO mail-pv0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752591Ab0GFNqR (ORCPT ); Tue, 6 Jul 2010 09:46:17 -0400 In-Reply-To: <20100706070355.GA14626@gondor.apana.org.au> Sender: linux-crypto-owner@vger.kernel.org List-ID: On 07/06/2010 12:03 AM, Herbert Xu wrote: > Justin P. Mattock wrote: >> The below fixes a warning message generated by GCC >> CC [M] drivers/crypto/hifn_795x.o >> drivers/crypto/hifn_795x.c: In function 'hifn_flush': >> drivers/crypto/hifn_795x.c:2021:23: warning: variable 'ctx' set but not used >> drivers/crypto/hifn_795x.c: In function 'hifn_process_queue': >> drivers/crypto/hifn_795x.c:2142:23: warning: variable 'ctx' set but not used >> >> Please have a look, and let me know if this is legit or not. >> >> Signed-off-by: Justin P. Mattock >> >> --- >> drivers/crypto/hifn_795x.c | 10 ++++++++++ >> 1 files changed, 10 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/crypto/hifn_795x.c b/drivers/crypto/hifn_795x.c >> index 16fce3a..e7aa4dc 100644 >> --- a/drivers/crypto/hifn_795x.c >> +++ b/drivers/crypto/hifn_795x.c >> @@ -2036,6 +2036,11 @@ static void hifn_flush(struct hifn_device *dev) >> spin_lock_irqsave(&dev->lock, flags); >> while ((async_req = crypto_dequeue_request(&dev->queue))) { >> ctx = crypto_tfm_ctx(async_req->tfm); >> + if (ctx) { >> + dprintk("%s: Flushing shash. %s\n", >> + dev->name, ctx); >> + return; >> + } > > This certainly does not look right! Returning with IRQs disabled > is considered to be rude. Well, I certainly did not want to be rude..(searching for the right return etc.. when a function returns null gives not vary much results) > > I believe the right answer is to delete the line initialising ctx. > > Thanks, o.k. then I'll resend with delete the line initialising ctx Thanks for having a look.. Justin P. Mattock