From: Randy Dunlap Subject: Re: [PATCH 1/1] crypto: api.c: add comments to crypto_alg_lookup and crypto_alg_larval_lookup Date: Thu, 4 Nov 2010 12:51:25 -0700 Message-ID: <20101104125125.ed177cf4.rdunlap@xenotime.net> References: <1288900188-19034-1-git-send-email-mark.a.allyn@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org To: Mark Allyn Return-path: Received: from xenotime.net ([72.52.115.56]:60009 "HELO xenotime.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752038Ab0KDTvc (ORCPT ); Thu, 4 Nov 2010 15:51:32 -0400 Received: from chimera.site ([173.50.240.230]) by xenotime.net for ; Thu, 4 Nov 2010 12:51:26 -0700 In-Reply-To: <1288900188-19034-1-git-send-email-mark.a.allyn@intel.com> Sender: linux-crypto-owner@vger.kernel.org List-ID: On Thu, 4 Nov 2010 12:49:48 -0700 Mark Allyn wrote: > This is resubmitted due to errors in style > > Signed-off-by: Mark A. Allyn > --- > crypto/api.c | 15 +++++++++++++++ > 1 files changed, 15 insertions(+), 0 deletions(-) > > diff --git a/crypto/api.c b/crypto/api.c > index 033a714..0314083 100644 > --- a/crypto/api.c > +++ b/crypto/api.c > @@ -193,6 +193,13 @@ static struct crypto_alg *crypto_larval_wait(struct crypto_alg *alg) > return alg; > } > > +/** > + * crypto_alg_lookup() - return crypto_alg structure for an algorithm > + * @name: text string containing name of algorithm > + * @type: crypto type defined in include/linux/crypto.h > + * @mask: mask of allowable crypto types (use or'd list > + * of types as defined in include/linux/crypto.h) > + */ > struct crypto_alg *crypto_alg_lookup(const char *name, u32 type, u32 mask) > { > struct crypto_alg *alg; > @@ -205,6 +212,14 @@ struct crypto_alg *crypto_alg_lookup(const char *name, u32 type, u32 mask) > } > EXPORT_SYMBOL_GPL(crypto_alg_lookup); > > +/** > + * crypto_alg_larval_lookup() - returns large value (larval) crypto_alg > + * structure for an algorithm That function name still does not match the actual name below. > + * @name: text string containing name of algorithm > + * @type: crypto type defined in include/linux/crypto.h > + * @mask: mask of allowable crypto types (use or'd list > + * of types as defined in include/linux/crypto.h) > + */ > struct crypto_alg *crypto_larval_lookup(const char *name, u32 type, u32 mask) > { > struct crypto_alg *alg; > -- --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***