From: David Howells Subject: Re: [PATCH v1.3 4/4] keys: add new key-type encrypted Date: Tue, 16 Nov 2010 14:08:44 +0000 Message-ID: <23151.1289916524@redhat.com> References: <1289849751.3027.17.camel@localhost.localdomain> <1289694826.3257.82.camel@localhost.localdomain> <1289595738.2731.80.camel@localhost.localdomain> <1289404309-15955-5-git-send-email-zohar@linux.vnet.ibm.com> <1289404309-15955-1-git-send-email-zohar@linux.vnet.ibm.com> <26689.1289591135@redhat.com> <27900.1289597013@redhat.com> <8268.1289837934@redhat.com> Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, keyrings@linux-nfs.org, linux-crypto@vger.kernel.org, Jason Gunthorpe , James Morris , David Safford , Rajiv Andrade , Mimi Zohar To: Mimi Zohar Return-path: Received: from mx1.redhat.com ([209.132.183.28]:4288 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755062Ab0KPOJL (ORCPT ); Tue, 16 Nov 2010 09:09:11 -0500 In-Reply-To: <1289849751.3027.17.camel@localhost.localdomain> Sender: linux-crypto-owner@vger.kernel.org List-ID: Mimi Zohar wrote: > Am assuming you mean something like this: > > keyctl add encrypted name "new trusted:master-key-name keylen" ring > keyctl add encrypted name "new user:master-key-name keylen" ring > > and, as you said, works without changing the API. No, that's not what I mean. I maeant that when your internal functions look for the user key, they should preface the description with a prefix. It should be handled in request_user_key() or request_master_key(). The description given to request_trusted_key() should have the prefix applied there. There's no need to mention it at all in the encrypted key add_key command line. David