From: Herbert Xu Subject: Re: 2.6.37-rc7: Regression: b43: crashes in hwrng_register() Date: Wed, 5 Jan 2011 16:47:35 +1100 Message-ID: <20110105054735.GA7773@gondor.apana.org.au> References: <20101231024653.GA24879@gondor.apana.org.au> <20101231085103.GA31935@darkside.kls.lan> <20110104043338.GA27604@gondor.apana.org.au> <20110104121957.GA27114@darkside.kls.lan> <20110104123824.GA31557@gondor.apana.org.au> <20110104125722.GC27114@darkside.kls.lan> <20110104224238.GA4978@gondor.apana.org.au> <20110104230644.GJ27114@darkside.kls.lan> <20110105003020.GA5751@gondor.apana.org.au> <20110105035222.GA8762@darkside.kls.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii To: Mario 'BitKoenig' Holbe , Larry Finger , Matt Mackall , LKML , Linux Crypto Maili Return-path: Received: from helcar.apana.org.au ([209.40.204.226]:56420 "EHLO fornost.hengli.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750938Ab1AEFrs (ORCPT ); Wed, 5 Jan 2011 00:47:48 -0500 Content-Disposition: inline In-Reply-To: <20110105035222.GA8762@darkside.kls.lan> Sender: linux-crypto-owner@vger.kernel.org List-ID: On Wed, Jan 05, 2011 at 04:52:22AM +0100, Mario 'BitKoenig' Holbe wrote: > > According to the VIA PadLock Programming Guide, XSTORE increments EDI by > the number of bytes stored. > This did obviously not matter as long as the buffer was "sufficiently > distant", but now you have the buffer close on the stack and I believe, > the optimizer crops up, hence the EDI increment begins to matter. Interesting. So your compiler was producing incorrect output. What version of gcc were you using? Please attach the assembly output of the function in question. Thanks! -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt