From: Larry Finger Subject: Re: 2.6.37-rc7: Regression: b43: crashes in hwrng_register() Date: Thu, 06 Jan 2011 07:56:05 -0600 Message-ID: <4D25C9F5.1060907@lwfinger.net> References: <20110104123824.GA31557@gondor.apana.org.au> <20110104125722.GC27114@darkside.kls.lan> <20110104224238.GA4978@gondor.apana.org.au> <20110104230644.GJ27114@darkside.kls.lan> <20110105003020.GA5751@gondor.apana.org.au> <20110105035222.GA8762@darkside.kls.lan> <20110105054735.GA7773@gondor.apana.org.au> <20110105131621.GA24769@darkside.kls.lan> <20110106061241.GA18939@gondor.apana.org.au> <20110106131516.GB8803@darkside.kls.lan> <20110106133541.GA22030@gondor.apana.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Mario 'BitKoenig' Holbe , Matt Mackall , LKML , Linux Crypto Mailing List , Harald Welte , Michal Ludvig To: Herbert Xu Return-path: Received: from mail-vw0-f46.google.com ([209.85.212.46]:39144 "EHLO mail-vw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751914Ab1AFNz5 (ORCPT ); Thu, 6 Jan 2011 08:55:57 -0500 In-Reply-To: <20110106133541.GA22030@gondor.apana.org.au> Sender: linux-crypto-owner@vger.kernel.org List-ID: On 01/06/2011 07:35 AM, Herbert Xu wrote: > On Thu, Jan 06, 2011 at 02:15:16PM +0100, Mario 'BitKoenig' Holbe wrote: >> >> The patch helps. No crashes, meaningful random data - perfect. >> I still have 2 small annotations... > > Thanks for testing! > >> 1. Having ECX on the clobber-list is not really necessary. >> XSTORE doesn't touch ECX at all. >> REP XSTORE would touch it, but for this ECX would be an input anyways. > > The documentation wasn't clear whether ECX would be updated without > the REP prefix so I included it to be on the safe side. Unfortunately > my only VIA machine is on another continent at the moment so I can't > test it myself. Can you verify that ECX isn't changed without the > REP prefix? > >> 2. Would you mind doing the same for EDX as you did for EDI? >> This doesn't really change anything currently, but will probably help >> avoiding a debug-session like ours somewhere in the future :) > > According to my documentation EDX isn't be modified (nor would it > make sense as it would break REP XSTORE). Are you seeing anything > different? As an interested observer, I think this routine needs some really detailed comments. Larry