From: Jamie Iles Subject: Re: [PATCH 01/16] crypto: omap-aes: don't treat NULL clk as an error Date: Wed, 12 Jan 2011 21:51:40 +0000 Message-ID: <20110112215140.GA2822@pulham.picochip.com> References: <1294749833-32019-1-git-send-email-jamie@jamieiles.com> <1294749833-32019-2-git-send-email-jamie@jamieiles.com> <1294861135.14458.5.camel@Tobias-Karnat> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jamie Iles , Dmitry Kasatkin , Aaro Koskinen , linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org To: Tobias Karnat Return-path: Received: from mail-ww0-f66.google.com ([74.125.82.66]:38077 "EHLO mail-ww0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755542Ab1ALV5e (ORCPT ); Wed, 12 Jan 2011 16:57:34 -0500 Content-Disposition: inline In-Reply-To: <1294861135.14458.5.camel@Tobias-Karnat> Sender: linux-crypto-owner@vger.kernel.org List-ID: On Wed, Jan 12, 2011 at 08:38:55PM +0100, Tobias Karnat wrote: > You have included linux/err.h a second time. Doh! Good spot, thanks. I've checked the rest of the series and this was the only patch with the duplicated include. Jamie 8<------------------------------------------------------------------- >From 75cef47f02ea19b94203f287eaaddc644c51ce30 Mon Sep 17 00:00:00 2001 From: Jamie Iles Date: Tue, 11 Jan 2011 09:48:26 +0000 Subject: [PATCH] crypto: omap-aes: don't treat NULL clk as an error clk_get() returns a struct clk cookie to the driver and some platforms may return NULL if they only support a single clock. clk_get() has only failed if it returns a ERR_PTR() encoded pointer. Cc: Dmitry Kasatkin Cc: linux-crypto@vger.kernel.org Signed-off-by: Jamie Iles --- drivers/crypto/omap-aes.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c index 799ca51..10a9180 100644 --- a/drivers/crypto/omap-aes.c +++ b/drivers/crypto/omap-aes.c @@ -830,9 +830,9 @@ static int omap_aes_probe(struct platform_device *pdev) /* Initializing the clock */ dd->iclk = clk_get(dev, "ick"); - if (!dd->iclk) { + if (IS_ERR(dd->iclk)) { dev_err(dev, "clock intialization failed.\n"); - err = -ENODEV; + err = PTR_ERR(dd->iclk); goto err_res; } -- 1.7.3.4