From: Shirish Pargaonkar Subject: Re: [PATCH] cifs: Replace cifs md5 hashing functions with kernel crypto APIs Date: Fri, 21 Jan 2011 10:16:39 -0600 Message-ID: References: <1295622245-10581-1-git-send-email-shirishpargaonkar@gmail.com> <20110121104228.60262dd2@tlielax.poochiereds.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: smfrench-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, linux-cifs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-crypto-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, metze-eUNUBHrolfbYtjvyW6yDsg@public.gmane.org To: Jeff Layton Return-path: In-Reply-To: <20110121104228.60262dd2-9yPaYZwiELC+kQycOl6kW4xkIHaj4LzF@public.gmane.org> Sender: linux-cifs-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-crypto.vger.kernel.org On Fri, Jan 21, 2011 at 9:42 AM, Jeff Layton wrote= : > On Fri, 21 Jan 2011 09:04:05 -0600 > shirishpargaonkar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote: > >> From: Shirish Pargaonkar >> >> Replace remaining use of md5 hash functions local to cifs module >> with kernel crypto APIs. >> Remove header and source file containing those local functions. >> >> >> Signed-off-by: Shirish Pargaonkar >> --- >> =A0fs/cifs/Makefile =A0 =A0 =A0| =A0 =A02 +- >> =A0fs/cifs/cifsencrypt.c | =A0 =A01 - >> =A0fs/cifs/link.c =A0 =A0 =A0 =A0| =A0 59 +++++++-- >> =A0fs/cifs/md5.c =A0 =A0 =A0 =A0 | =A0366 --------------------------= ----------------------- >> =A0fs/cifs/md5.h =A0 =A0 =A0 =A0 | =A0 38 ----- >> =A0fs/cifs/smbencrypt.c =A0| =A0 =A01 - >> =A06 files changed, 51 insertions(+), 416 deletions(-) >> =A0delete mode 100644 fs/cifs/md5.c >> =A0delete mode 100644 fs/cifs/md5.h >> > > Very nice. The CIFS parts look good to me, and I'm always fond of > reducing the code we need to support as well as the cifs.ko footprint= =2E > Assuming that mfsymlink support still works after this patch... I did test briefly, e.g. creating symlinks and deleting them. Hoping Stefan Metzmacher will comment. I did verify that the (md5) hash value was different for different actu= alpaths > > Reviewed-by: Jeff Layton >