From: Jesper Juhl Subject: RE: [PATCH] rfc4106, Intel, AES-NI: Don't leak memory in rfc4106_set_hash_subkey(). Date: Fri, 11 Feb 2011 15:47:03 +0100 (CET) Message-ID: References: <4d502ccb.p+rKcuFjWCnBlXY9%tadeusz.struk@intel.com> <20110211142647.GA3920@ucw.cz> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: Pavel Machek , "Struk, Tadeusz" , "herbert@gondor.hengli.com.au" , "linux-kernel@vger.kernel.org" , "linux-crypto@vger.kernel.org" , "O Mahony, Aidan" , "Hoban, Adrian" To: "Paoloni, Gabriele" Return-path: Received: from swampdragon.chaosbits.net ([90.184.90.115]:23766 "EHLO swampdragon.chaosbits.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752260Ab1BKOsM (ORCPT ); Fri, 11 Feb 2011 09:48:12 -0500 In-Reply-To: Sender: linux-crypto-owner@vger.kernel.org List-ID: On Fri, 11 Feb 2011, Paoloni, Gabriele wrote: > Well anyway I think that the return value of "ablkcipher_request_alloc(ctr_tfm, GFP_KERNEL)" has to be changed from -EINVAL to -ENOMEM in case of failure. That is why would stay on the patch that Tadeusz proposed. Otherwise Juhl should send another one.... > I'll take a look again later this evening when I get home from work. -- Jesper Juhl http://www.chaosbits.net/ Plain text mails only, please. Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html