From: Jan Glauber <jang@linux.vnet.ibm.com>
Subject: Re: [PATCH 7/8] tcrypt: disable 384 bit key XTS test
Date: Wed, 20 Apr 2011 17:19:52 +0200
Message-ID: <1303312792.10786.12.camel@localhost.localdomain>
References: <20110419192913.888086020@linux.vnet.ibm.com>
	 <20110419193250.074519442@linux.vnet.ibm.com>
	 <20110420003350.GB10285@gondor.apana.org.au>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Cc: linux-crypto@vger.kernel.org
To: Herbert Xu <herbert@gondor.apana.org.au>
In-Reply-To: <20110420003350.GB10285@gondor.apana.org.au>
Sender: linux-crypto-owner@vger.kernel.org

On Wed, 2011-04-20 at 08:33 +0800, Herbert Xu wrote:
> On Tue, Apr 19, 2011 at 09:29:20PM +0200, jang@linux.vnet.ibm.com wrote:
> > From: Jan Glauber <jang@linux.vnet.ibm.com>
> > 
> > XTS mode is only defined for 256 and 512 bit key lengths. s390 only
> > implements these two modes and running the test with a 384 bit key
> > will stop the speed test with an error. Remove the superfluous key
> > lenght.
> > 
> > Signed-off-by: Jan Glauber <jang@linux.vnet.ibm.com>
> 
> That's a limitation specific to your hardware.  As the existing xts
> currently supports 384-bit keys, we can't remove it for compatibility
> reasons.  So please add it as a fallback to your implementation.

I see, will try to hack something together.

Bad thing is, we don't even have a test vector for the 384 bit key length
and the standards don't provide one.

Should I resend when I'm finished or would you like to drop this patch
from the series?

Cheers,
Jan